Skip to content

Lab: Suppress warning#9384

Merged
sloriot merged 4 commits intoCGAL:mainfrom
afabri:Lab-disable_warning-GF
Apr 9, 2026
Merged

Lab: Suppress warning#9384
sloriot merged 4 commits intoCGAL:mainfrom
afabri:Lab-disable_warning-GF

Conversation

@afabri
Copy link
Copy Markdown
Member

@afabri afabri commented Mar 19, 2026

Summary of Changes

Suppress warning issued by gcc.

include/CGAL/Three/Viewer_interface.h:42:21: warning: defining ‘CGAL::Three::Viewer_interface’, which previously failed to be complete in a SFINAE context [-Wsfinae-incomplete=]
   42 | class VIEWER_EXPORT Viewer_interface : public CGAL::QGLViewer{
      |                     ^~~~~~~~~~~~~~~~

Release Management

  • Affected package(s): Lab
  • License and copyright ownership: unchanged

@afabri afabri self-assigned this Mar 19, 2026
@afabri afabri added Warnings For an issue about warnings, or a pull-request that fixes warnings CGAL 3D demo Ready to be tested labels Mar 19, 2026
@afabri afabri requested a review from sloriot March 19, 2026 07:50
@afabri afabri added this to the 6.2-beta milestone Mar 19, 2026
@afabri
Copy link
Copy Markdown
Member Author

afabri commented Mar 24, 2026

The warning is gone for the test platform mentioned above, but it triggers a new warning on other gcc plarforms

include/CGAL/Three/Viewer_interface.h:37:34: warning: unknown warning group '-Wsfinae-incomplete', ignored [-Wunknown-warning-option]
#  pragma GCC diagnostic ignored "-Wsfinae-incomplete"

Either we refine the conditions of the #ifdef or we at the same time add the -Wunknown-warning-option.

@sloriot
Copy link
Copy Markdown
Member

sloriot commented Mar 24, 2026

Generate this warnings on several platforms:

/Users/geometryfactory/CGAL/testsuite/CGAL-6.2-Ic-137/include/CGAL/Three/Viewer_interface.h:37:34: warning: unknown warning group '-Wsfinae-incomplete', ignored [-Wunknown-warning-option]
#  pragma GCC diagnostic ignored "-Wsfinae-incomplete"

@sloriot
Copy link
Copy Markdown
Member

sloriot commented Apr 9, 2026

Successfully tested in CGAL-6.2-Ic-150

@sloriot sloriot merged commit 9ec3716 into CGAL:main Apr 9, 2026
9 checks passed
@sloriot sloriot deleted the Lab-disable_warning-GF branch April 9, 2026 15:55
@lrineau lrineau linked an issue Apr 14, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CGAL 3D demo Tested Warnings For an issue about warnings, or a pull-request that fixes warnings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

warning in Lab

2 participants