83 compute external cost and internal cost globally#90
Merged
francosansone merged 31 commits intosb-graph-devfrom Aug 12, 2025
Merged
Conversation
This reverts commit e04f815.
Kalashnikovni
approved these changes
Jul 28, 2025
joaquinffernandez
approved these changes
Aug 11, 2025
| auto s1 = PartitionStrategyDistributive(number_of_partitions, graph, set_fact); | ||
| auto s1 = PartitionStrategyDistributive(number_of_partitions, graph); | ||
| add_strategy(s1, pre_order); | ||
| #if TRY_MULTIPLE_STRATEGIES |
Collaborator
There was a problem hiding this comment.
Nit: Not for this PR, but I would probably add an option to try multiple strategies instead of a compilation flag.
| /// @param node set of nodes we want to know its connections. | ||
| /// @return a set of nodes connected to the function parameter. | ||
| SBG::LIB::Set get_adjacents(const SBG::LIB::SBG& graph, const SBG::LIB::Set& node, SBG::LIB::SetAF& set_fact, SBG::LIB::MapAF& map_fact); | ||
| SBG::LIB::Set get_adjacents(const SBG::LIB::SBG& graph, const SBG::LIB::Set& node); |
Collaborator
There was a problem hiding this comment.
Maybe for another PR, but I guess we can modify:
SBG::LIB::WeightedSBGraph build_sb_graph(const std::string& filename, SBG::LIB::SetAF& set_fact,
SBG::LIB::MapAF& map_fact, SBG::LIB::PWMapAF& pw_map_fact);
to be:
SBG::LIB::WeightedSBGraph build_sb_graph(const std::string& filename, SBG::LIB::PWMapAF& pw_map_fact);
and access the map and set factories using SBG::LIB::PWMapAF& just to simplify the interfaces.
Collaborator
Author
There was a problem hiding this comment.
Done in the last commit.
francosansone
deleted the
83-compute-external-cost-and-internal-cost-globally
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many changes were done to avoid recomputing internal and external communication while refining partitions.
CommunicationCostclass has three internal structures:Keep in mind that in the following examplesit will be compared multi-threading executions (the previous one) with single thread executions.
Execution time:
Examples changing the number of partitions for "air conditioners with controller" model with size 1000 and 4 sections.
Results changing the amount of connections between nodes for spl neurons model: