Choose better data structures for cost information during refinement process#95
Merged
francosansone merged 1 commit intosb-graph-devfrom Aug 13, 2025
Conversation
joaquinffernandez
approved these changes
Aug 13, 2025
francosansone
deleted the
iss-94-choose-better-data-structures-for-cost-information-during-refinement-process
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very little and local change. Change
CostMatrixImbalancefromstd::settostd::list. The insertion cost forstd::setisO(log(n))beingnthe size of the set. We don't need all the elements sorted, we only need to know which one is the one with greatest gain.This PR changes
CostMatrixImbalancetostd::listto make the insertion costO(1), comparing the new element with the one with better gain.After a quick look, the partitioning time for the air conditioner with with a centralized controller goes from ~160ms to ~140ms.