New QU-fitting models, and minor bug fix#72
New QU-fitting models, and minor bug fix#72AlecThomson merged 13 commits intoCIRADA-Tools:new_qufitfrom jackieykma:master
Conversation
AlecThomson
left a comment
AlecThomson
left a comment
There was a problem hiding this comment.
Nice updates @jackieykma ! Whilst we're in here I think we can also change the polfrac minima to 0 in the priors. I think most fitter are robust enough to handle this
|
Apologies for the delay! I've made the changes of minimum fracpol to 0.0 as requested |
|
Hey @jackieykma - this is looking great! I may make one other change to use some simple for loops to avoid repetition in the multi-component files. But that can happen later! One final request - could you please add some tests for the new models? See |
AlecThomson
added
enhancement
|
P.S. if you want a hand to develop the tests, happy to help out |
AlecThomson
left a comment
AlecThomson
left a comment
There was a problem hiding this comment.
We need to add some tests...
|
@jackieykma I've merged into a new branch and I'll take care of the tests :) |
* New QU-fitting models, and minor bug fix (#72) * Improved model files to be more descriptive, and added 3 new models * Fixed error message not showing correct path to model files * Added triple Faraday thin model * Fixed indentation error * Changed fracpol minimum to 0.0 * Changed fracpol minimum to 0.0 * Changed fracpol minimum to 0.0 * Changed fracpol minimum to 0.0 * Changed fracpol minimum to 0.0 * Changed fracpol minimum to 0.0 * Changed fracpol minimum to 0.0 * Changed fracpol minimum to 0.0 * Changed fracpol minimum to 0.0 * Test models * Standardise test names * Ignore * Testing tests * Verbose output * Updated new models to better LaTeX strings. Made math of models immune to black reformatting, for readability. * Re-introduced Alec's new QUfitting tests. Disabled the values tests, because they were too sensitive to variations between runs. Only tests if QU-fitting runs, but not the output values. * Fixing tests. --------- Co-authored-by: Yik Ki (Jackie) Ma <yikki.ma@anu.edu.au> Co-authored-by: Alec Thomson (S&A, Kensington WA) <alec.thomson@csiro.au>
2 participants
Hi Cameron,
I've made the following changes for the QU-fitting:
Happy to discuss about any of these changes as needed!