Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the CI/CD workflow configuration to implement tag-based releases and adds a dedicated CI workflow for pull requests and development branch pushes.
Changes:
- Modified publish workflow to trigger on version tags instead of master branch pushes
- Added a new CI workflow for automated testing on pull requests and develop branch
- Bumped package version from 1.0.7 to 1.0.8
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Version bump to 1.0.8 |
| .github/workflows/publish.yml | Changed trigger from master branch to version tags (v*..) and moved permissions to job level |
| .github/workflows/ci.yml | New workflow for running linting, tests, and builds on PRs and develop branch pushes |
Comment on lines
+9
to
15
| permissions: | ||
| contents: read | ||
| id-token: write | ||
|
|
||
| jobs: | ||
| publish: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Moving permissions from job-level to workflow-level may grant broader access than necessary. Consider whether all jobs in this workflow truly need these permissions, or if they should remain scoped to specific jobs.
Suggested change
| permissions: | |
| contents: read | |
| id-token: write | |
| jobs: | |
| publish: | |
| runs-on: ubuntu-latest | |
| jobs: | |
| publish: | |
| runs-on: ubuntu-latest | |
| permissions: | |
| contents: read | |
| id-token: write |
Zaiidmo
added a commit
that referenced
this pull request
Feb 2, 2026
* parents translate, components receive plain strings * 1.0.3 * tested in local, bug fixed * 1.0.4 * 1.0.5 * forgot and reset password done * 1.0.6 * Feat/forgot password (#8) * parents translate, components receive plain strings * 1.0.3 * tested in local, bug fixed * 1.0.4 * forgot and reset password done * 1.0.6 * Docs: Add Export Strategy and Workflow Guidelines (#9) * docs: add copilot development instructions - Add React component library development guidelines - Include accessibility and i18n requirements - Document component patterns and testing standards - Add release checklist * docs: create task documentation structure for UI module - Add active tasks folder with UI-MODULE- prefix - Establish workflow for UI component tasks - Add UI-specific documentation focus (accessibility, responsive) * docs: add export strategy and workflow guidelines - Define export strategy (Components + Hooks + Types only) - Document rationale for public API exports - Add workflow with UI-MODULE- prefix convention - Include breaking changes handling for component APIs - Add task documentation structure examples * 1.0.7 * Updated workflows (#10) * ops: updated release pipeline to run only on version changes, and created ci workflow * 1.0.8 * docs(workflow): add Git Flow and npm version requirements (#11) - Add Git Flow branching strategy (develop/master) - Document npm version command before push - Add prepublishOnly hook recommendation - Update workflow with proper branch management - Clear warnings about PR targeting Co-authored-by: Reda Channa <r.channa@ciscod.com> Co-authored-by: Zaiid Moumni <141942826+Zaiidmo@users.noreply.github.com> * docs: added different documentations * 1.0.9 * ops: updated publishing trigger * verify email page done * merged * 1.0.10 --------- Co-authored-by: Zaiidmo <zaiidmoumnii@gmail.com> Co-authored-by: RedaChannaCiscode <r.channa@ciscod.com> Co-authored-by: Zaiid Moumni <141942826+Zaiidmo@users.noreply.github.com> Co-authored-by: Ciscode-Admin <info@ciscod.com>
Zaiidmo
added a commit
that referenced
this pull request
Feb 2, 2026
* parents translate, components receive plain strings * 1.0.3 * tested in local, bug fixed * 1.0.4 * 1.0.5 * forgot and reset password done * 1.0.6 * Feat/forgot password (#8) * parents translate, components receive plain strings * 1.0.3 * tested in local, bug fixed * 1.0.4 * forgot and reset password done * 1.0.6 * Docs: Add Export Strategy and Workflow Guidelines (#9) * docs: add copilot development instructions - Add React component library development guidelines - Include accessibility and i18n requirements - Document component patterns and testing standards - Add release checklist * docs: create task documentation structure for UI module - Add active tasks folder with UI-MODULE- prefix - Establish workflow for UI component tasks - Add UI-specific documentation focus (accessibility, responsive) * docs: add export strategy and workflow guidelines - Define export strategy (Components + Hooks + Types only) - Document rationale for public API exports - Add workflow with UI-MODULE- prefix convention - Include breaking changes handling for component APIs - Add task documentation structure examples * 1.0.7 * Updated workflows (#10) * ops: updated release pipeline to run only on version changes, and created ci workflow * 1.0.8 * docs(workflow): add Git Flow and npm version requirements (#11) - Add Git Flow branching strategy (develop/master) - Document npm version command before push - Add prepublishOnly hook recommendation - Update workflow with proper branch management - Clear warnings about PR targeting Co-authored-by: Reda Channa <r.channa@ciscod.com> Co-authored-by: Zaiid Moumni <141942826+Zaiidmo@users.noreply.github.com> * docs: added different documentations * 1.0.9 * ops: updated publishing trigger * verify email page done * merged * 1.0.10 * updated endpoints --------- Co-authored-by: Zaiidmo <zaiidmoumnii@gmail.com> Co-authored-by: RedaChannaCiscode <r.channa@ciscod.com> Co-authored-by: Zaiid Moumni <141942826+Zaiidmo@users.noreply.github.com> Co-authored-by: Ciscode-Admin <info@ciscod.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Checklist
npm run lintpassesnpm run typecheckpassesnpm testpassesnpm run buildpassesnpx changeset) if this affects consumersNotes