Merged
Conversation
…ache-module-service
…pters, service, and decorators
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive Jest test suite for CacheKit’s core utilities (key resolution, singleton ref), primary service API (CacheService), decorators (@Cacheable/@CacheEvict), module wiring (CacheModule), and both store adapters (in-memory and Redis via ioredis-mock).
Changes:
- Added unit/integration-style tests across utilities, service, decorators, module, and adapters (including Redis behavior via
ioredis-mock). - Added
ioredis-mockas a dev dependency and updated the lockfile. - Updated Jest configuration (raised global coverage thresholds to 85% and enabled
forceExit).
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/resolve-cache-key.util.spec.ts | Adds unit coverage for placeholder interpolation and edge cases. |
| src/utils/cache-service-ref.spec.ts | Tests singleton accessor behavior and error messaging. |
| src/services/cache.service.spec.ts | Tests CacheService API behavior, TTL resolution, and error propagation in wrap(). |
| src/decorators/cacheable.decorator.spec.ts | Verifies cache-aside behavior, TTL forwarding, and sync/async method support. |
| src/decorators/cache-evict.decorator.spec.ts | Verifies post-success eviction behavior, error path, and sync/async support. |
| src/cache-kit.module.spec.ts | Tests dynamic module registration paths and onModuleInit() wiring into CacheServiceRef. |
| src/adapters/redis-cache-store.adapter.spec.ts | Adds Redis adapter contract tests using ioredis-mock. |
| src/adapters/in-memory-cache-store.adapter.spec.ts | Adds in-memory adapter contract + TTL behavior tests. |
| jest.config.ts | Raises coverage thresholds and enables forceExit. |
| package.json | Adds ioredis-mock to devDependencies. |
| package-lock.json | Lockfile updates for ioredis-mock and transitive dependencies. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Checklist
npm run lintpassesnpm run typecheckpassesnpm testpassesnpm run buildpassesnpx changeset) if this affects consumersNotes