Skip to content

fix(ci): fix SonarCloud coverage — use src/**/*.spec.ts instead of test/ #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
y-aithnini merged 1 commit into from
Apr 6, 2026
+1 −1
Merged

fix(ci): fix SonarCloud coverage — use src/**/*.spec.ts instead of test/ #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
-Dsonar.organization=${{ env.SONAR_ORGANIZATION }}
-Dsonar.projectKey=${{ env.SONAR_PROJECT_KEY }}
-Dsonar.sources=src
-Dsonar.tests=test
-Dsonar.test.inclusions=src/**/*.spec.ts
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jest.config.ts runs tests from both src/**/*.spec.ts and test/**/*.test.ts, but the Sonar config now only marks src/**/*.spec.ts as tests. This will cause the test/ suite (e.g. test/smoke.test.ts) to be ignored/misclassified in SonarCloud. Consider setting sonar.tests to include both src and test and expanding sonar.test.inclusions accordingly (and, if needed, excluding **/*.spec.ts from sonar.sources to avoid counting tests as main sources).

Suggested change
-Dsonar.test.inclusions=src/**/*.spec.ts
-Dsonar.tests=src,test
-Dsonar.test.inclusions=src/**/*.spec.ts,test/**/*.test.ts
-Dsonar.exclusions=src/**/*.spec.ts

Copilot uses AI. Check for mistakes.
-Dsonar.javascript.lcov.reportPaths=coverage/lcov.info

- name: SonarCloud Quality Gate
Expand Down
Loading