Skip to content

implemented test suite#5

Merged
y-aithnini merged 2 commits intodevelopfrom
feature/COMPT-53-test-suite
Apr 9, 2026
Merged

implemented test suite#5
y-aithnini merged 2 commits intodevelopfrom
feature/COMPT-53-test-suite

Conversation

@y-aithnini
Copy link
Copy Markdown

Summary

  • What does this PR change?

Why

  • Why is this change needed?

Checklist

  • Added/updated tests (if behavior changed)
  • npm run lint passes
  • npm run typecheck passes
  • npm test passes
  • npm run build passes
  • Added a changeset (npx changeset) if this affects consumers

Notes

  • Anything reviewers should pay attention to?

@y-aithnini y-aithnini requested a review from a team as a code owner April 9, 2026 10:31
Copilot AI review requested due to automatic review settings April 9, 2026 10:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an initial Jest test suite for the core ConfigKit APIs and tightens Jest coverage thresholds.

Changes:

  • Added unit tests for defineConfig() / ConfigDefinition.parse() and ConfigValidationError.
  • Added unit + integration tests for defineNamespace(), NamespacedConfig.asProvider(), DuplicateNamespaceError, and @InjectConfig().
  • Added integration tests for ConfigModule registration modes and increased global Jest coverage thresholds to 85%.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
src/errors/config-validation.error.spec.ts Unit tests for ConfigValidationError formatting/identity behavior.
src/define-namespace.spec.ts Tests namespace definition, provider factory behavior, and DI integration via @InjectConfig().
src/define-config.spec.ts Tests defineConfig() and parse() behavior across success/failure cases.
src/config.module.spec.ts NestJS integration tests for ConfigModule/ConfigService registration paths.
jest.config.ts Raises global coverage thresholds from 80% to 85%.

@y-aithnini y-aithnini merged commit f047941 into develop Apr 9, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants