Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an initial Jest test suite for the core ConfigKit APIs and tightens Jest coverage thresholds.
Changes:
- Added unit tests for
defineConfig()/ConfigDefinition.parse()andConfigValidationError. - Added unit + integration tests for
defineNamespace(),NamespacedConfig.asProvider(),DuplicateNamespaceError, and@InjectConfig(). - Added integration tests for
ConfigModuleregistration modes and increased global Jest coverage thresholds to 85%.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/errors/config-validation.error.spec.ts | Unit tests for ConfigValidationError formatting/identity behavior. |
| src/define-namespace.spec.ts | Tests namespace definition, provider factory behavior, and DI integration via @InjectConfig(). |
| src/define-config.spec.ts | Tests defineConfig() and parse() behavior across success/failure cases. |
| src/config.module.spec.ts | NestJS integration tests for ConfigModule/ConfigService registration paths. |
| jest.config.ts | Raises global coverage thresholds from 80% to 85%. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Checklist
npm run lintpassesnpm run typecheckpassesnpm testpassesnpm run buildpassesnpx changeset) if this affects consumersNotes