removed template files and added new tests#7
Merged
y-aithnini merged 3 commits intodevelopfrom Apr 10, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the leftover “example kit” template boilerplate from the package and expands @ciscode/config-kit’s public API around typed config ergonomics and async module registration patterns, with accompanying tests and a version bump.
Changes:
- Removed template/example module files (controller/service/repository/DTO/entity/guard/decorator/module) from
src/. - Added
InferConfig<T>type helper,ConfigService.getAll(), andregisterAsync()support foruseClass/useExisting. - Added/updated unit + integration tests and bumped package version / changelog.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/services/example.service.ts | Removed template service boilerplate. |
| src/repositories/example.repository.ts | Removed template repository boilerplate. |
| src/guards/example.guard.ts | Removed template guard boilerplate. |
| src/example-kit.module.ts | Removed template module boilerplate. |
| src/entities/example.entity.ts | Removed template entity boilerplate. |
| src/dto/create-example.dto.ts | Removed template DTO boilerplate. |
| src/dto/update-example.dto.ts | Removed template DTO boilerplate. |
| src/decorators/example.decorator.ts | Removed template decorator boilerplate. |
| src/controllers/example.controller.ts | Removed template controller boilerplate. |
| src/index.ts | Exported InferConfig and ConfigModuleOptionsFactory from the public API. |
| src/define-config.ts | Added InferConfig<T> type helper. |
| src/define-config.spec.ts | Added tests covering InferConfig<T> usage. |
| src/config.service.ts | Added ConfigService.getAll() to retrieve the validated config object. |
| src/config.module.ts | Extended registerAsync() to support useClass / useExisting via a shared async provider builder. |
| src/config.module.spec.ts | Added integration tests for getAll() and registerAsync() class-based patterns. |
| package.json | Bumped version to 0.3.0. |
| CHANGELOG.md | Added a 0.3.0 entry describing the new API surface and template removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Checklist
npm run lintpassesnpm run typecheckpassesnpm testpassesnpm run buildpassesnpx changeset) if this affects consumersNotes