Develop by a-elkhiraooui-ciscode · Pull Request #4 · CISCODE-MA/NotificationKit-UI

a-elkhiraooui-ciscode · 2026-03-30T09:01:27Z

Summary

What does this PR change?

Why

Why is this change needed?

Checklist

Added/updated tests (if behavior changed)
npm run lint passes
npm run typecheck passes
npm test passes
npm run build passes
Added a changeset (npx changeset) if this affects consumers

Notes

Anything reviewers should pay attention to?

- Fix SONAR_PROJECT_KEY (critical bug fix) - Add dependabot.yml for dependency management - Add sonarqube_mcp.instructions.md - Standardize branch triggers and Actions versions - Pin SonarQube actions to commit SHA

- Add comprehensive copilot-instructions.md guiding notification UI development - Align documentation with other frontend packages - Establish clear naming conventions and testing standards - Define module structure and development workflow

… clean, verify, prepublishOnly)

- Add comprehensive instruction files in .github/instructions/ - Includes copilot, testing, bugfix, features, general guidelines - Standardize documentation across all repositories

- Change trigger from tag push to master branch push - Add tag validation using 'git describe --exact-match' - Prevent failed workflows on feature branch tag pushes - Maintain semantic versioning with mandatory tags

* Develop (#1) * ops: updated workflows and unit tests coverage rules * chore: update test coverage rules * chore: setting up env * chore: fixed prettier format errors * ops: updated workflow trigger * 0.0.1 * first version * fixed a style issue and added changeset --------- Co-authored-by: Zaiid Moumni <141942826+Zaiidmo@users.noreply.github.com>

Copilot

Pull request overview

This PR turns the repository from a template into a functional notification/toast component library (@ciscode/ui-notification-kit), adding the notification store/provider + UI components, styling pipeline (Tailwind), tests, and CI/release automation.

Changes:

Implement notification models, store, React context/provider, hooks, and UI components (including portal-based viewport rendering).
Add Tailwind/PostCSS build pipeline and publishable CSS asset export (./style.css).
Add Vitest + RTL test setup and CI workflows for PR validation/release checks/publishing.

Reviewed changes

Copilot reviewed 55 out of 57 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
vitest.config.ts	Expands Vitest config (jsdom, setup, coverage).
tsup.config.ts	Normalizes tsup config + formatting.
tailwind.config.mjs	Adds Tailwind config (RTL plugin, zIndex scale).
tailwind.config.js	Duplicate Tailwind config file (same as .mjs).
src/utils/noop.ts	Removes noop utility.
src/utils/index.ts	Removes placeholder utils exports (now empty export).
src/store/notificationStore.ts	Adds core notification store logic (state/history, lifecycle).
src/store/index.ts	Exports store entrypoint.
src/models/notification.ts	Adds notification types/config models.
src/models/index.ts	Exports models entrypoint.
src/index.ts	Updates public API exports (adds models/store, explicit `.js`).
src/hooks/useNotification.ts	Adds consumer hook for NotificationContext.
src/hooks/useNoop.ts	Removes noop hook.
src/hooks/useClearOnNavigate.ts	Adds navigation-clearing hook.
src/hooks/useAccessibility.ts	Adds focus trap + live region hooks.
src/hooks/index.ts	Replaces placeholder hook exports with real hooks.
src/context/NotificationContext.tsx	Adds notification context types + provider context object.
src/components/index.ts	Replaces placeholder exports with notification components.
src/components/index.css	Adds CSS entry that imports Tailwind input + component CSS.
src/components/NotificationViewport.tsx	Adds portal-based viewport rendering.
src/components/NotificationProvider.tsx	Adds provider wiring store + context + viewport.
src/components/NotificationProgress.tsx	Adds progress bar component.
src/components/NotificationItem.tsx	Adds notification item UI + timers + a11y behavior.
src/components/NotificationIcons.css	Adds keyframes/animation utility classes.
src/components/NotificationIcon.tsx	Adds icon rendering logic (type-based + custom icons).
src/components/NotificationContainer.tsx	Adds positioning container + grouping by position.
src/components/NotificationActionList.tsx	Adds action button list for notifications.
src/components/NoopButton.tsx	Removes noop button component.
src/assets/styles/style.css	Adds Tailwind directives + `sr-only` utility.
src/tests/setup.ts	Adds RTL cleanup + jest-dom setup for Vitest.
src/tests/notificationStore.test.ts	Adds unit tests for NotificationStore behavior.
src/tests/NotificationProvider.test.tsx	Adds provider integration tests.
src/tests/NotificationItem.a11y.test.tsx	Adds basic a11y assertions for NotificationItem.
postcss.config.mjs	Adds PostCSS config (Tailwind + autoprefixer).
postcss.config.js	Duplicate PostCSS config file (same as .mjs).
package.json	Renames package, adds scripts, exports, deps/devDeps updates.
package-lock.json	Updates lockfile for new dependencies/tooling.
eslint.config.js	Updates ignored paths + relaxes/adjusts TS/React rules.
README.md	Replaces template README with library documentation/usage.
.prettierrc.json	Expands Prettier settings.
.husky/_/.gitignore	Adjusts husky internal gitignore.
.github/workflows/release-check.yml	Adds release-check workflow (optional Sonar).
.github/workflows/publish.yml	Adds publish workflow to NPM.
.github/workflows/pr-validation.yml	Updates PR validation trigger behavior.
.github/workflows/ci-release-check.yml	Removes old release check workflow.
.github/workflows/cd-release.yml	Removes old publish workflow.
.github/sonarqube_mcp.instructions.md	Adds SonarQube MCP instructions doc.
.github/instructions/testing.instructions.md	Adds detailed testing guidelines.
.github/instructions/sonarqube_mcp.instructions.md	Adds SonarQube MCP instructions (instructions folder).
.github/instructions/general.instructions.md	Adds general module engineering guidelines.
.github/instructions/features.instructions.md	Adds feature development workflow guidelines.
.github/instructions/copilot-instructions.md	Adds Copilot usage guidelines (instructions folder).
.github/instructions/components.instructions.md	Adds component development standards.
.github/instructions/bugfix.instructions.md	Adds bugfix workflow guidelines.
.github/dependabot.yml	Adds Dependabot config for npm/actions.
.github/copilot-instructions.md	Adds top-level Copilot guidelines doc.
.changeset/bright-owls-approve.md	Adds changeset for first functional release.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/__tests__/NotificationProvider.test.tsx

package.json

postcss.config.js

.github/workflows/release-check.yml

vitest.config.ts

src/hooks/useAccessibility.ts

src/components/NotificationItem.tsx

src/store/notificationStore.ts

package.json

…ckages - Replace git tag --list strategy with package.json-driven tag validation in all 16 publish workflows; use git rev-parse to verify the exact tag exists rather than guessing the latest repo-wide tag - Update error guidance to reflect feat/** → develop → master flow - Standardize dependabot to npm-only, grouped, monthly cadence across all 16 packages; remove github-actions ecosystem updates - Add missing dependabot.yml to AuthKit-UI, ChartKit-UI, HealthKit, HooksKit, paymentkit, StorageKit

…to develop

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

sonarqubecloud · 2026-03-30T10:36:27Z

Quality Gate passed

Issues
21 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Zaiidmo and others added 14 commits February 24, 2026 10:47

ops: updated workflows and unit tests coverage rules

2f2b47d

chore: update test coverage rules

d3ac058

chore: setting up env

f6f33da

chore: fixed prettier format errors

c796292

ops: updated workflow trigger

10ca35d

0.0.1

63d0ec5

chore: standardize workflows and ci/cd

f6e7e9c

- Fix SONAR_PROJECT_KEY (critical bug fix) - Add dependabot.yml for dependency management - Add sonarqube_mcp.instructions.md - Standardize branch triggers and Actions versions - Pin SonarQube actions to commit SHA

chore: standardize npm scripts (lint, format, typecheck, test, build,…

55c46de

… clean, verify, prepublishOnly)

chore: Standardize ESLint and Prettier configs with best practices

3324e22

docs: add standardized instruction files structure

33520e3

- Add comprehensive instruction files in .github/instructions/ - Includes copilot, testing, bugfix, features, general guidelines - Standardize documentation across all repositories

ci: update publish workflow to require version tags

92789c6

- Change trigger from tag push to master branch push - Add tag validation using 'git describe --exact-match' - Prevent failed workflows on feature branch tag pushes - Maintain semantic versioning with mandatory tags

ops: UPDATED publish workflow and dependabot PR limits

3b4e4a0

a-elkhiraooui-ciscode requested review from a team and Copilot March 30, 2026 09:01

Copilot started reviewing on behalf of a-elkhiraooui-ciscode March 30, 2026 09:01 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Zaiidmo added 4 commits March 30, 2026 10:42

Merge branch 'develop' of github.com:CISCODE-MA/NotificationKit-Ui in…

0f3c58a

…to develop

fix: merging conflicts

9f690e4

fix: missing dependencies for test coverage

3259b53

Copilot AI review requested due to automatic review settings March 30, 2026 09:51

Copilot AI reviewed Mar 30, 2026

View reviewed changes

y-aithnini previously approved these changes Mar 30, 2026

View reviewed changes

tests: added test files to pass thresholds

6af195e

Zaiidmo dismissed y-aithnini’s stale review via 6af195e March 30, 2026 10:09

fix: release check Sonar test directory

11b4d92

Copilot AI review requested due to automatic review settings March 30, 2026 10:22

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Zaiidmo previously approved these changes Mar 30, 2026

View reviewed changes

fix: added lcovto reporter

1e6fa36

Zaiidmo dismissed their stale review via 1e6fa36 March 30, 2026 10:35

Zaiidmo approved these changes Mar 30, 2026

View reviewed changes

Zaiidmo merged commit 22cdf6e into master Mar 30, 2026
2 checks passed

Zaiidmo deleted the develop branch March 30, 2026 10:36

Zaiidmo restored the develop branch March 30, 2026 10:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop#4

Develop#4
Zaiidmo merged 21 commits intomasterfrom
develop

a-elkhiraooui-ciscode commented Mar 30, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

sonarqubecloud bot commented Mar 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

a-elkhiraooui-ciscode commented Mar 30, 2026

Summary

Why

Checklist

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 30, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants