Treat account tokens as runtime-only; remove token-only account support and always refresh tokens on admin actions#122
Merged
CJackHwang merged 2 commits intodevfrom Mar 21, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca08bb66b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CJackHwang
added a commit
that referenced
this pull request
Mar 21, 2026
Merge pull request #122 from CJackHwang/codex/refactor-configuration-to-remove-token-support Treat account tokens as runtime-only; remove token-only account support and always refresh tokens on admin actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tokenas a runtime-only value.emailormobileand remove legacy support for token-only accounts.Description
Config.ClearAccountTokens()and call it when loading from env/file, when computing sync hash, and when saving/exporting (Store.Save,saveLocked,ExportJSONAndBase64) to striptokenfrom persisted or exported JSON.Account.Identifier()return empty when neitheremailnormobileis present, and removed token-only account handling across the admin/pool codepaths.DS.Login(...)to refresh runtime tokens during account testing anddeleteAllSessions, and persist the refreshed token only at runtime viaStore.UpdateAccountToken(not in persisted config).tokenfrom being accepted during incoming account import/updates by ignoringtokenintoAccountandupdateConfigmerge logic, and addedincoming.ClearAccountTokens()inconfigImport.internal/accounttests andinternal/admintests.webuito change labels from "Test"/"Testing" to "Refresh token"/"Refreshing..." and related copy reflecting token-refresh semantics.internal/admin/token_runtime_http_test.goto validate that importedtokenfields are ignored and that runtime token refresh occurs but exported config omits tokens.Testing
internal/config,internal/account,internal/adminandinternal/authtest suites such asTestLoadStoreClearsTokensFromConfigInput,TestPoolSkipsTokenOnlyAccount,TestListAccountsUsesEmailIdentifier,TestTestAccount_BatchModeOnlyCreatesSession, and newTestConfigImportIgnoresTokenFieldInPayload; all tests passed.TestConfigImportIgnoresTokenFieldInPayloadandTestAccountTestRefreshesRuntimeTokenButExportOmitsToken, which succeeded and validated import/export/token refresh behavior.go test ./...completed successfully across the modified packages.Codex Task