Preserve code fences around standalone tool JSON and add marker-output guards#132
Merged
CJackHwang merged 1 commit intodevfrom Mar 21, 2026
Merged
Preserve code fences around standalone tool JSON and add marker-output guards#132CJackHwang merged 1 commit intodevfrom
CJackHwang merged 1 commit intodevfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was
linked to
issues
Mar 21, 2026
CJackHwang
added a commit
that referenced
this pull request
Mar 21, 2026
Merge pull request #132 from CJackHwang/codex/toolcallhistory-6t7271 Preserve code fences around standalone tool JSON and add marker-output guards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
trimWrappingJSONFenceandopenFenceStartBeforetointernal/adapter/openai/tool_sieve_core.goand the correspondingtrimWrappingJSONFenceininternal/js/helpers/stream-tool-sieve/sieve.jsto only strip opening fences that truly wrap standalone tool JSON.findToolSegmentStartandconsumeToolCaptureto use the new fence helpers and to preserve trailing prose/closing fences when appropriate.[TOOL_CALL_HISTORY]or[TOOL_RESULT_HISTORY]markers ininternal/adapter/claude/handler_utils.goandinternal/adapter/openai/handler_toolcall_format.goand updated related tests to expect the new instructions.TestHandleStreamStandaloneToolCallAfterClosedFenceKeepsFencein Go and thesieve preserves closed fence before standalone tool payloadtest in Node, plus minor updates to existing prompt/build tests.Testing
internal/adapter/openaiandinternal/adapter/claude, and the new/updated tests (e.g.TestHandleStreamStandaloneToolCallAfterClosedFenceKeepsFence) passed.tests/node/stream-tool-sieve.test.js), including the new fence-preservation test, and they passed.finish_reason=tool_callsand no leakage of rawtool_callsor stray code fences were validated and succeeded.Codex Task