Sanitize leaked tool-history markers, simplify normalization, and add managed token refresh#135
Merged
CJackHwang merged 4 commits intodevfrom Mar 21, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6758514c61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CJackHwang
added a commit
that referenced
this pull request
Mar 21, 2026
Merge pull request #135 from CJackHwang/codex/add-global-token-refresh-logic Sanitize leaked tool-history markers, simplify normalization, and add managed token refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
[TOOL_CALL_HISTORY]/[TOOL_RESULT_HISTORY]) into user-visible responses across streaming and non-streaming paths.Description
sanitizeLeakedToolHistoryininternal/adapter/openai/tool_history_sanitize.goto stripTOOL_CALL_HISTORYandTOOL_RESULT_HISTORYblocks using a regex and integrate it where final text or incremental chunks are emitted, including calls inchat_stream_runtime,responses_stream_runtime_core,handler_chat, andresponses_handler.evt.Contentand parsed partsp.Text).[TOOL_CALL_HISTORY]/[TOOL_RESULT_HISTORY]markers from message normalization and prompt-building logic by simplifyingmessage_normalize.goand corresponding tests to treat tool outputs as passthrough content.extractToolHistoryBlockintool_sieve_core.goand the JS equivalent ininternal/js/helpers/stream-tool-sieve/sieve.js.tool_history_sanitize_test.goand update existing normalization and prompt tests to reflect the passthrough model; update node sieve tests to assert swallowed history blocks.auth.Resolverininternal/auth/request.go, includingensureManagedToken,shouldForceRefresh,markTokenRefreshedNow, andclearTokenRefreshMarkwith a default refresh interval, and add a test verifying forced refresh behavior inrequest_test.go.Testing
message_normalize_test.go,prompt_build_test.go,tool_history_sanitize_test.go, andrequest_test.go), and they passed locally.tests/node/stream-tool-sieve.test.js) after adding history-block coverage, and the changes passed locally.Codex Task