[Follow-up] Preserve empty tool completion turns in OpenAI prompt normalization#139
Merged
CJackHwang merged 1 commit intodevfrom Mar 21, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tool/functionmessages when their normalizedcontentwas empty, which removes the signal that a tool call completed and can trigger repeated tool calls or missing final answers.Description
tool/functionturns innormalizeOpenAIMessagesForPromptby emitting a"null"placeholder whennormalizeOpenAIContentForPromptreturns an empty string for those roles instead of skipping the message.tool/functionmessages mapped to theuserrole as before so tool results remain part of the prompt stream.TestNormalizeOpenAIMessagesForPrompt_EmptyToolContentPreservedAsNullininternal/adapter/openai/message_normalize_test.gothat verifies empty tool output is preserved as the"null"placeholder.Testing
go test ./internal/adapter/openaiand the package tests passed (ok).Codex Task