Preserve tool call/result roundtrip and raw payloads across Claude, Gemini and OpenAI adapters#147
Merged
CJackHwang merged 3 commits intodevfrom Mar 22, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59bf78d2c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CJackHwang
added a commit
that referenced
this pull request
Mar 22, 2026
Merge pull request #147 from CJackHwang/codex/fix-tool-call-history-retrieval Preserve tool call/result roundtrip and raw payloads across Claude, Gemini and OpenAI adapters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tool_callsandtoolmessages.Description
normalizeClaudeMessagesto split text blocks, converttool_useblocks into assistanttool_callsenvelopes, converttool_resultblocks intotoolmessages, and preserve raw unknown blocks as JSON viaformatClaudeBlockRaw.buildClaudeToolPromptto remove legacy marker instructions and keep clear instructions about not printing tool-call JSON, and added helpersnormalizeClaudeToolUseToAssistantandnormalizeClaudeToolResultToToolMessage.normalizeOpenAIMessagesForPrompt, splitting logic intobuildAssistantContentForPrompt,buildToolContentForPrompt, andnormalizeAssistantToolCallsForPromptso assistanttool_callsand tool/function roles are preserved astoolmessages with serialized envelopes.normalizeResponsesInputItemWithStateto preserve assistanttool_callsand to includetool_call_id/namemetadata for tool/function roles.MessagesPrepareto handletoolrole formatting when building the final prompt.convert_messages_test.go, extended Claude tests inhandler_util_test.go, and multiple updates to OpenAI normalization tests inmessage_normalize_test.goto assert preservation of tool envelopes and metadata.Testing
go test ./...across the repository and all tests completed successfully.internal/adapter/openai/message_normalize_test.goto reflect preservedtoolrole and assistanttool_calls, and those tests passed.internal/adapter/gemini/convert_messages_test.goand updated Claude tests ininternal/adapter/claude/handler_util_test.go, and both test suites passed.Codex Task