Sync tool-call compat fixtures and update node test to match permissive tool-call policy#155
Merged
CJackHwang merged 1 commit intocodex/investigate-tool-execution-bugs-in-output-7ocr8ffrom Mar 22, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
47d4499
into
codex/investigate-tool-execution-bugs-in-output-7ocr8f
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Unit Gates (Go + Node)to fail.Description
tests/compat/expectedto reflect the new permissive behavior and preserved tool-name forms by changingtoolcalls_allowlist_empty.json,toolcalls_unknown_name.json,toolcalls_case_insensitive_canonical.json,toolcalls_loose_normalize.json, andtoolcalls_namespace_tail_normalize.jsonto include the original names and markrejectedByPolicy: false.tests/node/chat-stream.test.jsto expect that unknown incremental tool-call deltas are kept (and recorded inseen) instead of being blocked, by changing the test name and assertions forfilterIncrementalToolCallDeltasByAllowed.Testing
./tests/scripts/check-refactor-line-gate.shand it completed successfully../tests/scripts/run-unit-all.sh(Go + Node) and the full unit gate passed locally with all Go and Node tests green after the fixture and test updates.npm ci --prefix webui && npm run build --prefix webuiand it completed successfully.Codex Task