refactor: Relocate JavaScript source and Node.js test files to dedicated directories and extract OpenAI stream runtime tool call finalization logic.#41
Conversation
…eaming and tool calls, enhance admin and account management, and introduce new UI features for settings, API testing, and Vercel sync.
…smoke test status validation
… as content and filtering streamed tool calls by schema.
…hance tool call handling and configuration options
…ed tool choice failures are correctly handled for malformed payloads.
… and add tests to validate its structure.
…ameter for API key detection.
…nhanced Admin API endpoints with related documentation and deployment updates.
…ted directories and extract OpenAI stream runtime tool call finalization logic.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4017b87c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (out.length === 0 && parsed.length > 0) { | ||
| for (const tc of parsed) { | ||
| if (!tc || !tc.name) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
When all parsed calls are filtered out (for example, the model emits an undeclared tool name), this fallback loop repopulates out from the original parsed list, so the Node/Vercel stream path still emits tool_calls and finish_reason=tool_calls for rejected tools. In this commit the Go parser behavior and compat expectations were updated to reject unknown tool names, so this block creates a cross-runtime behavior regression and causes the unknown_name JS compat case to fail.
Useful? React with 👍 / 👎.
1 participant
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
📝 补充信息 | Additional Information