Fix URL Predication/Regex in SettingsViewController.swift#74
Merged
CLARATION merged 1 commit intoCLARATION:mainfrom Sep 21, 2024
Merged
Fix URL Predication/Regex in SettingsViewController.swift#74CLARATION merged 1 commit intoCLARATION:mainfrom
CLARATION merged 1 commit intoCLARATION:mainfrom
Conversation
`urlPredicate` was set to match only `https://`, it didn't allow for a URL to be entered. This should allow for the URL to be fully entered/saved Should fix issue CLARATION#73
CLARATION
approved these changes
Sep 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urlPredicatewas set to match onlyhttps://andhttp://, it didn't allow for a URL to be entered.This should allow for the URL to be fully entered/saved
It also limits it to just
httpsurls, since that is apparently require by iOS 18+ anywaysShould fix issue #73