Remove superfluous `from_` classmethods in Centroids

[peanutfun]

As far as I can see, nobody reads in Centroids on their own. Reading/creating centroids is always part of reading in Hazard data (...or is it?). Therefore, I see no reason why we should keep from_ classmethods in Centroids that are not used anywhere else. I compiled a list of these methods. The following classmethods are only called by tests, and not by any other code in either Climada Core or Petals:

• climada_python/climada/hazard/centroids/centr.py

  Line 244 in e26f900

  def from_geodataframe(cls, gdf, geometry_alias='geom'):

• climada_python/climada/hazard/centroids/centr.py

  Line 303 in e26f900

  def from_pix_bounds(cls, xf_lat, xo_lon, d_lat, d_lon, n_lat, n_lon, crs=DEF_CRS):

Can we remove them?

[chahank]

Sometimes it is useful to be able to create Centroids separately from the Hazard. But I would agree that we can remove the said methods. These operations can easily be done otherwise just from the __init__.

[peanutfun]

Both methods have been deprecated with #721 and can be removed after the next release.

[chahank]

This had been reversed in the latest rewriting of the Centroids as geodataframe. I think it is still in general useful to have the possibility to create ones own centroids. For instance, when creating a tropical cyclone object with local storms, but on a standardized global set of centroids.

I would close this issue if this is fine with you @peanutfun .

[peanutfun]

@chahank This issue is about removing only from_geodataframe and from_pix_bounds. We already deprecated them. Do you now want to keep them in?

[chahank]

These methods are part of the centroids currently (and not deprecated). I think this is good like this. Centroids are now much slimmer and thus having a method to make centroids sound useful.

Would you insist on removing them? Then how would centroids be initialized?

[chahank]

To be clear, now there are 3 from_ methods:

• from_exposures: useful if the exposures is already defined to get a minimal hazard
• from_geodataframe: useful if the geometries are already defined (avoids an extra array to geometry conversion)
• from_pnts_bounds: useful to define a grid.