Skip to content

Secure phillip's page#75

Merged
domdomegg merged 5 commits intoCLSB-Programming:masterfrom
jcxldn:patch-2
Mar 14, 2017
Merged

Secure phillip's page#75
domdomegg merged 5 commits intoCLSB-Programming:masterfrom
jcxldn:patch-2

Conversation

@jcxldn
Copy link
Copy Markdown
Contributor

@jcxldn jcxldn commented Mar 13, 2017

I like https. 👍

@jcxldn jcxldn mentioned this pull request Mar 13, 2017
@domdomegg
Copy link
Copy Markdown
Member

Might be a bit risky storing that image of a cookie - potential copyright violation. Try using a HTTPS origin or a freely licensed picture instead

Copy link
Copy Markdown
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use https://vignette2.wikia.nocookie.net/mspafetchmodus/images/a/ab/Chocolate_chip_cookie.jpg/revision/latest?cb=20100726200146 as source instead of hosting image ourselves

@jcxldn
Copy link
Copy Markdown
Contributor Author

jcxldn commented Mar 14, 2017

Done @domdomegg

@domdomegg domdomegg merged commit 49d4b21 into CLSB-Programming:master Mar 14, 2017
@jcxldn jcxldn deleted the patch-2 branch March 15, 2017 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants