Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

HBF interface#364

Merged
vlimant merged 4 commits intomasterfrom
HBF_interface
Feb 1, 2019
Merged

HBF interface#364
vlimant merged 4 commits intomasterfrom
HBF_interface

Conversation

@vlimant
Copy link
Copy Markdown
Contributor

@vlimant vlimant commented Jan 31, 2019

goes in the direction of #360 . @sharad1126 you should get used to the command line tool.
there are some cleanup to be finalized so that we delete elements from the db when the workflow(s) go out of scope

@vlimant vlimant changed the title Hbf interface HBF interface Jan 31, 2019
@sharad1126
Copy link
Copy Markdown
Contributor

ok you mean to bypass/force-complete/on-hold through the command line tool directly instead of adding it in the json files?

@vlimant
Copy link
Copy Markdown
Contributor Author

vlimant commented Jan 31, 2019

with this PR, the afs files are totally deprecated and one adds something with

./wtcActions.py --action hold --keyword <workflow name, or keyword>

using --pop option to remove it from the DB.
at the moment, the db is fully synchronize with whether was in the json files on afs from the allowed users.

@vlimant
Copy link
Copy Markdown
Contributor Author

vlimant commented Jan 31, 2019

if you are happy with the way to set these up via the command line, we merge and move on.
this fixes #273 somehow, as things are revertable. setting the hold in actor needs to be updated though

@vlimant
Copy link
Copy Markdown
Contributor Author

vlimant commented Feb 1, 2019

definitely solving #273 as then one just needs to pop the action in the command line

@vlimant vlimant mentioned this pull request Feb 1, 2019
@sharad1126
Copy link
Copy Markdown
Contributor

I think we can do this. It is better in all ways. Also I guess for #273 you mean we just pop it out right?

@vlimant vlimant merged commit c58d95a into master Feb 1, 2019
@sharad1126
Copy link
Copy Markdown
Contributor

@vlimant what is the keyword here? I mean it should be name of the original workflow only right?

@vlimant
Copy link
Copy Markdown
Contributor Author

vlimant commented Feb 1, 2019

either the workflow name of some text that is found in workflow names.
this could be evolved to regexp, if one feels it should ; I don't speak regexp :-(

@sharad1126
Copy link
Copy Markdown
Contributor

ok great.. thanks ... I'll try this out once I have some request we need to bypass/force-complete/keep on hold. I will also add this to the twiki so it would be helpful

@sharad1126
Copy link
Copy Markdown
Contributor

@thongonary FYI

@vlimant
Copy link
Copy Markdown
Contributor Author

vlimant commented Feb 1, 2019

if there are no entries to bypass/hold/force from your end atm, we should just purge the records

@sharad1126
Copy link
Copy Markdown
Contributor

sharad1126 commented Feb 4, 2019

@vlimant I was trying to put a workflow on hold and it is giving me permission denied! Can you please have a look?

[sagarwal@vocms0275 WmAgentScripts]$ ./wtcActions.py --action hold --keyword pdmvserv_task_PPS-RunIIFall17GS-00007__v1_T_190126_170646_635
-bash: ./wtcActions.py: Permission denied

@sharad1126
Copy link
Copy Markdown
Contributor

So just to update for future reference - we need the proxy and export PYTHONPATH=$PYTHONPATH:/usr/lib64/python2.7/site-packages as it is a unified script.

sharad1126 pushed a commit that referenced this pull request Nov 12, 2019
@sharad1126
Copy link
Copy Markdown
Contributor

sharad1126 commented Feb 4, 2020

@vlimant can you please confirm that since we are using the wtcActions.py and soon the JIRA search(once tested and merged), we don't need https://github.com/CMSCompOps/WmAgentScripts/blob/master/utils.py#L6563 and https://github.com/CMSCompOps/WmAgentScripts/blob/master/utils.py#L6497 and can be commented(probably removed) from the code?
@todor-ivanov FYI

@vlimant
Copy link
Copy Markdown
Contributor Author

vlimant commented Feb 4, 2020

the file interface is completely unused already anyways, so those can go away

@todor-ivanov
Copy link
Copy Markdown
Contributor

Thanks @vlimant @sharad1126

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants