Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

force-complete and bypass directly from jira#484

Merged
sharad1126 merged 5 commits intomasterfrom
FC_bypass_from_jira
Feb 4, 2020
Merged

force-complete and bypass directly from jira#484
sharad1126 merged 5 commits intomasterfrom
FC_bypass_from_jira

Conversation

@vlimant
Copy link
Copy Markdown
Contributor

@vlimant vlimant commented Jan 31, 2020

with regards to https://its.cern.ch/jira/browse/CMSCOMPPR-11343 if one wants to avoid having to operate manually, see this PR.
adding a "cmsunified please do force-complete wfname" or "cmsunified please do bypass wfname" will result in the desired action

@sharad1126
Copy link
Copy Markdown
Contributor

sharad1126 commented Feb 4, 2020

@vlimant I tried to test the PR(https://its.cern.ch/jira/browse/CMSCOMPPR-11364) and got the following error:

sagarwal is bypassing pgunnell_Run2018D-v1-EGamma-12Nov2019_UL2018_1064p1_200113_211959_1205 from JIRA
Traceback (most recent call last):
  File "Unified/checkor.py", line 1573, in <module>
    checkor(url, spec, options=options)
  File "Unified/checkor.py", line 176, in checkor
    bypasses.update( keyword )
AttributeError: 'list' object has no attribute 'update'

I think it should be bypasses.extend(keyword) instead of

bypasses.update( keyword )

@sharad1126 sharad1126 self-assigned this Feb 4, 2020
@sharad1126 sharad1126 merged commit a9b954a into master Feb 4, 2020
Comment thread Unified/checkor.py
if keyword and user in actors:
print user,"is force-completing", keyword,"from JIRA"
bypasses.update( keyword )
bypasses.extend( keyword )
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because

l=range(10)
l.extend('keyword')
l
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 'k', 'e', 'y', 'w', 'o', 'r', 'd']

it should be append, and not extend

l=range(10)
l.append('keyword')
l
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 'keyword']

you are lucky we have been through f94c63c in the past, otherwise all current workflows in assistance would have been bypassed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for checking this. would have been really bad.

@sharad1126 sharad1126 deleted the FC_bypass_from_jira branch August 26, 2020 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants