Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Give detailed report of pylint test failures#606

Merged
sharad1126 merged 1 commit intoCMSCompOps:masterfrom
ishanrai05:pylint-errors
Jul 21, 2020
Merged

Give detailed report of pylint test failures#606
sharad1126 merged 1 commit intoCMSCompOps:masterfrom
ishanrai05:pylint-errors

Conversation

@ishanrai05
Copy link
Copy Markdown
Contributor

Status

ready

Description

Pylint will show errors only now.

Is it backward compatible (if not, which system it affects?)

Yes

Mention people to look at PRs

@sharad1126 @amaltaro

@ishanrai05
Copy link
Copy Markdown
Contributor Author

we also have the option to disable refactor and convention using --disable=R,C. Do we want to do that?

@amaltaro
Copy link
Copy Markdown
Contributor

amaltaro commented Jul 8, 2020

I'd rather keep seeing those in the reports, but doesn't fail the checks only based on them.

@sharad1126
Copy link
Copy Markdown
Contributor

I'd agree with @amaltaro

@sharad1126
Copy link
Copy Markdown
Contributor

@ishanrai05 any updates on this?

@sharad1126
Copy link
Copy Markdown
Contributor

@ishanrai05 can you please update this PR making sure pylint fails only on errors and warnings?

@ishanrai05 ishanrai05 force-pushed the pylint-errors branch 2 times, most recently from 56436f9 to 052bd64 Compare July 19, 2020 05:24
@ishanrai05
Copy link
Copy Markdown
Contributor Author

link to test

@ishanrai05
Copy link
Copy Markdown
Contributor Author

The pylint will not fail on errors now. It will simply give a report.

@ishanrai05 ishanrai05 changed the title show errors only in pylint Give detailed report of pylint test failures Jul 20, 2020
@sharad1126 sharad1126 merged commit ebfe6c8 into CMSCompOps:master Jul 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants