This repository was archived by the owner on Sep 12, 2024. It is now read-only.
add review dog with shell check#613
Merged
sharad1126 merged 2 commits intoCMSCompOps:masterfrom Jul 21, 2020
Merged
Conversation
Contributor
|
@ishanrai05 why did you remove the action to work on |
Contributor
Author
|
|
Contributor
|
@ishanrai05 yes but it won't work in case some one by mistake pushes directly to GH without a PR. so please change it to push and PR both. thanks. |
cc4c893 to
51a26c6
Compare
Contributor
Author
|
|
51a26c6 to
2d80031
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Ready. Tested on my branch here
Description
I added a review bot that will comment on the line with the lint error and link to how to solve it. It only works on changed lines.
Is it backward compatible (if not, which system it affects?)
Yes
Mention people to look at PRs
@sharad1126 @amaltaro