Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

add review dog with shell check#613

Merged
sharad1126 merged 2 commits intoCMSCompOps:masterfrom
ishanrai05:reviewdogShellcheck
Jul 21, 2020
Merged

add review dog with shell check#613
sharad1126 merged 2 commits intoCMSCompOps:masterfrom
ishanrai05:reviewdogShellcheck

Conversation

@ishanrai05
Copy link
Copy Markdown
Contributor

Status

Ready. Tested on my branch here

Description

I added a review bot that will comment on the line with the lint error and link to how to solve it. It only works on changed lines.

Is it backward compatible (if not, which system it affects?)

Yes

Mention people to look at PRs

@sharad1126 @amaltaro

@sharad1126
Copy link
Copy Markdown
Contributor

@ishanrai05 why did you remove the action to work on push?

@ishanrai05
Copy link
Copy Markdown
Contributor Author

pull request action will work even if we add a commit to our existing PR. I tested this on my branch on the link provided above. The push and pull request action are causing a double build.

@sharad1126
Copy link
Copy Markdown
Contributor

@ishanrai05 yes but it won't work in case some one by mistake pushes directly to GH without a PR. so please change it to push and PR both. thanks.

@ishanrai05 ishanrai05 force-pushed the reviewdogShellcheck branch from cc4c893 to 51a26c6 Compare July 17, 2020 13:19
@ishanrai05
Copy link
Copy Markdown
Contributor Author

ishanrai05 commented Jul 17, 2020

reviewdog does not work on push event because it needs a pull request to leave comments on. So I created another yaml file which will run on push event.

@ishanrai05 ishanrai05 force-pushed the reviewdogShellcheck branch from 51a26c6 to 2d80031 Compare July 21, 2020 03:18
@sharad1126 sharad1126 merged commit e625127 into CMSCompOps:master Jul 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants