AB2D-7048 Validate IDR Attribution Workflow in Production#1741
Merged
smirnovaae merged 22 commits intomainfrom Mar 25, 2026
Merged
AB2D-7048 Validate IDR Attribution Workflow in Production#1741smirnovaae merged 22 commits intomainfrom
smirnovaae merged 22 commits intomainfrom
Conversation
bennavapbc
reviewed
Mar 25, 2026
| public class SnowflakeConfig { | ||
|
|
||
| @Bean | ||
| @ConditionalOnProperty(name = "IDR_SNOWFLAKE_URL") |
Collaborator
There was a problem hiding this comment.
This is minor, but seems like app.snowflake.url should be used instead of IDR_SNOWFLAKE_URL given app.snowflake.url exists in application.properties.
bennavapbc
reviewed
Mar 25, 2026
bennavapbc
reviewed
Mar 25, 2026
|
|
||
| try { | ||
| while (rs.next()) { | ||
| String line = String.join(",", |
Collaborator
There was a problem hiding this comment.
Eventually would be good to move this logic to its own class for testability and separation of concerns
bennavapbc
approved these changes
Mar 25, 2026
bennavapbc
requested review from
Sadibhatla,
gfreeman-navapbc and
keeyanghoreshi-rgb
Sadibhatla
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/AB2D-7048
🛠 Changes
v3.coverage_v3_stagingtov3.coverage_v3ℹ️ Context
🧪 Validation
Terraform applied in prod, test and dev environments
Tested in Prod: