Skip to content

[ BB2-1495 ] Update ts-node to 10.8.1 to resolve issue#28

Merged
dtisza1 merged 1 commit intomasterfrom
dtisza1/BB2-1495-fix-error-update-tsnode-version
Aug 8, 2022
Merged

[ BB2-1495 ] Update ts-node to 10.8.1 to resolve issue#28
dtisza1 merged 1 commit intomasterfrom
dtisza1/BB2-1495-fix-error-update-tsnode-version

Conversation

@dtisza1
Copy link
Copy Markdown
Contributor

@dtisza1 dtisza1 commented Aug 5, 2022

JIRA Ticket:
BB2-1495

User Story or Bug Summary:

While reviewing BB2-1495, I found that the sample application is no longer working for me.

It was getting a server error similar to the following:

False expression: Non-string value passed to `ts.resolveTypeReferenceDirective` in typescript

Updating the ts-node package to 10.8.1 resolves this.

What Does This PR Do?

What Should Reviewers Watch For?

To review and test:

  1. Checkout the "master" branch.
  2. Clean up any docker images
  3. Perfom "docker-compose up -d"
  4. Look to see if you get this same error in the logs via "docker-compose logs -f"
  5. Checkout this PR branch.
  6. Clean up any docker images.
  7. Perform "docker-compose up -d"
  8. Verify the sample app is now working OK.

If you're reviewing this PR, please check these things, in particular:

  • TODO

@dtisza1 dtisza1 requested review from JFU-GIT and ajshred August 5, 2022 19:20
@dtisza1 dtisza1 self-assigned this Aug 5, 2022
Copy link
Copy Markdown

@ajshred ajshred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Copy Markdown
Contributor

@JFU-GIT JFU-GIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up!

@dtisza1 dtisza1 merged commit acbbdf0 into master Aug 8, 2022
@dtisza1 dtisza1 deleted the dtisza1/BB2-1495-fix-error-update-tsnode-version branch August 8, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants