Conversation
dtisza1
suggested changes
Jan 20, 2022
Contributor
There was a problem hiding this comment.
@JFU-GIT This is looking good.
Just a couple of snake vs. camel case renaming changes and including error code information is needed.
These should be changed to snake case for the following Python files:
For example:
server/src/data/Database.py -> database.py
server/src/utils/bb2Util.py -> bb2_util.py
server/src/utils/configUtil.py -> config_util.py
server/src/utils/userUtil.py -> user_util.py
| Debugging server component | ||
| -------------------------- | ||
| debugpy remote debugging enabled on port 5678 for server in docker compose, developer can attach to server from IDE e.g. vscode. | ||
|
No newline at end of file |
Contributor
There was a problem hiding this comment.
The corresponding ErrorResponses.md from the NodeJS/React PR should be added and referenced in this readme file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-896
User Story or Bug Summary:
As a 3rd party app, I should be able to understand what to do when I receive certain error messages from BB2 so that I can properly respond to my own users
AC:
Draft documentation for review for:
In the Node.JS and Python sample apps add in responsive design to show:
This PR is for applying similar error handling and retry logic to BB2 Sample App Python React.
What Should Reviewers Watch For?
If you're reviewing this PR, please check these things, in particular:
To facilitate the verification of retry failed requests, an instrumented BB2 server is deployed to sandbox canary:
put below line into your host file on you local machine:
10.246.44.54 sandbox.bluebutton.cms.gov
then verify retry on EOB request by following following steps:
Wait until the server and client components are up and running.
note, a waffle switch "simulate_500_error" is provisioned on sandbox which when "active", will produce a 500 error on fhir request, with error message: "Service temporarily unavailable, try again later, network connection refused".
From client webUI, click button "Authorize" to complete the beneficiary medicare.gov login, and grant access to the app, the corresponding EOB search will hit the simulated 500 network connection error, and the failed EOB request met the criteria for retry.
below is a sample server stdout showing the retry process, the 3rd attempt succeeded (by setting switch "simulate_500_error" to false soon after 2nd retry ...)
server_1 | Response status code: 500
server_1 | Response text: {"detail":"Service temporarily unavailable, try again later, network connection r
efused."}
server_1 | retrying started ...
server_1 | retry attempts: 1
server_1 | retry attempts: 2
server_1 | retry attempts: 3
server_1 | retry successful:
server_1 | Response status_code: 200
server_1 | Response stext: {"resourceType":"Bundle","id":"4b33d4ff-08da-4daa-8a54-ae033a395cb8","meta":{"la
stUpdated":"2021-09-23T13:36:42.530-04:00"},"type":"searchset","total":40,"link":[{"relation":"first","url":
.... FHIR bundle truncated for briefness.