Skip to content

Conversation

@whytheplatypus
Copy link
Contributor

@whytheplatypus whytheplatypus commented Dec 17, 2019

Change Details

Prevent any change to identity fields of the Crosswalk model after their initial value is set.
This provides confidence that identity is a constant within the system.

Acceptance Validation

  • the code is clean and readable
  • the tests assert that after the value is set identity fields in the crosswalk won't change

Feedback Requested

  • Are the tests enough?
  • Is the _ prefix python idiom enough to discourage future devs from accidentally undoing this?
  • Are there security concerns>

External References

Security Implications

None.

@whytheplatypus
Copy link
Contributor Author

depends on #771

@whytheplatypus whytheplatypus marked this pull request as ready for review December 20, 2019 19:02
Copy link

@switzersc-usds switzersc-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtisza1 dtisza1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@whytheplatypus whytheplatypus merged commit a75f291 into CMSgov:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants