-
Notifications
You must be signed in to change notification settings - Fork 28
BLUEBUTTON-1685 Immutable crosswalk #772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
whytheplatypus
merged 8 commits into
CMSgov:master
from
whytheplatypus:immutable-crosswalk-id
Dec 20, 2019
Merged
BLUEBUTTON-1685 Immutable crosswalk #772
whytheplatypus
merged 8 commits into
CMSgov:master
from
whytheplatypus:immutable-crosswalk-id
Dec 20, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
Contributor
Author
|
depends on #771 |
- also enforce uniqueness at db level
- also assert that the a user_id_hash is generally of the form expected
06a493f to
c75b517
Compare
5 tasks
switzersc-usds
approved these changes
Dec 20, 2019
switzersc-usds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dtisza1
approved these changes
Dec 20, 2019
Contributor
dtisza1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Details
Prevent any change to identity fields of the Crosswalk model after their initial value is set.
This provides confidence that identity is a constant within the system.
Acceptance Validation
Feedback Requested
_prefix python idiom enough to discourage future devs from accidentally undoing this?External References
Security Implications
None.