Conversation
juliareynolds-nava
previously approved these changes
Sep 30, 2025
gsf
requested changes
Oct 1, 2025
| workflows: ["tofu-format-and-validate"] | ||
| types: | ||
| - completed | ||
|
|
Member
There was a problem hiding this comment.
This is an interesting idea but I think it would end up triggering this workflow on every push that changes anything in the terraform directory. These workflows can instead run independently.
gsf
changed the title
.github/workflows/tofu-checks.yml
Outdated
| steps: | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||
| with: | ||
| fetch-depth: 0 |
Contributor
There was a problem hiding this comment.
why fetch-depth: 0 instead of 1? Does zero fetch everything?
Member
There was a problem hiding this comment.
I've dropped the need for commit comparison in this file but see python-checks for a place where I leverage tj-actions/changed-files to run tests on changed directories only.
gsf
previously approved these changes
Nov 20, 2025
gsf
changed the title
gsf
approved these changes
Nov 21, 2025
juliareynolds-nava
approved these changes
Nov 21, 2025
gsf
added a commit
that referenced
this pull request
Nov 25, 2025
## 🎫 Ticket https://jira.cms.gov/browse/PLT-212 ## 🛠 Changes Updated slack step and added concurrency in tofu workflows. ## ℹ️ Context These are small follow-ups on #320 to address errors seen in workflow runs here: https://github.com/CMSgov/cdap/actions/runs/19637506066/job/56231851306 ## 🧪 Validation I updated the trigger on the apply workflow temporarily to test in this PR. See run to demonstrate these changes here: https://github.com/CMSgov/cdap/actions/runs/19674308293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/PLT-212
🛠 Changes
CDAP tf workflows have been replaced by tofu fmt, tofu plan, and tofu apply workflows.
ℹ️ Context
This change errs on the side of running tofu apply more often since we should be running it daily to keep infra drift in check anyway. By doing so, we can run a job per application and environment, planning and applying tf for all services within each environment whenever there is a change to our terraform services.
🧪 Validation
See checks.