Skip to content

BCDA-9967: add model short name#461

Merged
bhagatparwinder merged 2 commits intomainfrom
BCDA-9967-add-model-short-name
May 5, 2026
Merged

BCDA-9967: add model short name#461
bhagatparwinder merged 2 commits intomainfrom
BCDA-9967-add-model-short-name

Conversation

@bhagatparwinder
Copy link
Copy Markdown
Contributor

🎫 Ticket

https://jira.cms.gov/browse/BCDA-9967

🛠 Changes

Adding model_name to the production and sandbox jobs view

ℹ️ Context

We want to have the Alternative Payment Model included in job request data so that it can be easily aggregated, without having to derive the model from each entity's CMS ID

🧪 Validation

Executed queries against prod/sandbox locally

@bhagatparwinder bhagatparwinder enabled auto-merge (squash) May 5, 2026 17:49
Copy link
Copy Markdown
Contributor

@jscott-nava jscott-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bhagatparwinder bhagatparwinder merged commit 745c660 into main May 5, 2026
17 checks passed
@bhagatparwinder bhagatparwinder deleted the BCDA-9967-add-model-short-name branch May 5, 2026 18:03
bhagatparwinder added a commit that referenced this pull request May 5, 2026
## 🎫 Ticket

https://jira.cms.gov/browse/BCDA-9967

## 🛠 Changes

Updated column order to match the existing view

## ℹ️ Context

Postgres rigidly maintains the existing column order for the existing
view unless we drop and recreate the view. The earlier PR merged (#461)
yields error:

```
SQL Error [42P16]: ERROR: cannot change name of view column "cms_id" to "benes_attributed_to_aco"
  Hint: Use ALTER VIEW ... RENAME COLUMN ... to change name of view column instead.
```

## 🧪 Validation

Executed/Updated views (without errors) and checked retrieved data
mianava pushed a commit that referenced this pull request May 6, 2026
## 🎫 Ticket

https://jira.cms.gov/browse/BCDA-9967

## 🛠 Changes

Adding `model_name` to the production and sandbox jobs view

## ℹ️ Context

We want to have the Alternative Payment Model included in job request
data so that it can be easily aggregated, without having to derive the
model from each entity's CMS ID

## 🧪 Validation

Executed queries against prod/sandbox locally
mianava pushed a commit that referenced this pull request May 6, 2026
## 🎫 Ticket

https://jira.cms.gov/browse/BCDA-9967

## 🛠 Changes

Updated column order to match the existing view

## ℹ️ Context

Postgres rigidly maintains the existing column order for the existing
view unless we drop and recreate the view. The earlier PR merged (#461)
yields error:

```
SQL Error [42P16]: ERROR: cannot change name of view column "cms_id" to "benes_attributed_to_aco"
  Hint: Use ALTER VIEW ... RENAME COLUMN ... to change name of view column instead.
```

## 🧪 Validation

Executed/Updated views (without errors) and checked retrieved data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants