Skip to content

[FFS-4307, FFS-4308] support VA implementation support SSN and non SSN based lookup, as well as disability determinations#72

Merged
iannorriswork merged 1 commit into
mainfrom
tweak-va-api
May 14, 2026
Merged

[FFS-4307, FFS-4308] support VA implementation support SSN and non SSN based lookup, as well as disability determinations#72
iannorriswork merged 1 commit into
mainfrom
tweak-va-api

Conversation

@iannorriswork
Copy link
Copy Markdown
Contributor

@iannorriswork iannorriswork commented May 13, 2026

Jira Ticket

Description

Turns out for VA eligibility determinations, two important notes:

  1. when searching with or without an SSN, they are two entirely different endpoints (fun!)
  2. the disability information we were grabbing was likely incorrect for the purposes of medicaid determinations---was less about the percentage, more about whether total disability applies (which can apply at 30% or at 100%).
  3. fixed a bug introduced with the Rails rewrite to make sure its using real transaction ids again.

Submitter Checklist

  • Jira Ticket: The relevant Jira ticket is linked in the header.
  • Evidence of Testing: I have included evidence of bench testing (e.g., terminal output, screenshots, logs) below.
  • Security Boundary: I have checked if any security boundaries are changing.
  • Backwards Compatibility: I have verified that these changes do not introduce any backwards compatibility issues.
  • I've updated the Confluence documentation, content in the /docs folder, and any API spec docs

Reviewer Checklist

  • Verification: I have verified that the changes work as intended.
  • Backwards Compatibility: I have confirmed that the code does not introduce any backwards compatibility issues.
  • Security & Privacy: I have reviewed the changes for potential security or privacy risks (e.g., PII handling).
  • Contract Compliance: If the public API contract changed, I have verified that it is reflected in api-spec/ and follows the organization's standards.
  • Code Quality: The code is clean, well-tested, and follows the established patterns in the codebase.
  • Code Quality: The code has unit and integration tests that cover relevant code changes.

Evidence of Testing

 curl -k --location 'localhost:3000/api/v0/veteran-disability-ratings' \                                                               
        --header 'Content-Type: application/json' \
        --data '{
                    "ssn": "796-12-7781",
                  "firstName": "Andrea",
                  "lastName": "Mitchell",
                  "dateOfBirth": "1959-12-01"
                }'
{"totalDisabilityStatus":true,"totalDisabilityStatusEffectiveDate":"1983-05-01","dataSource":"VA","metadata":{"apiVersion":"1.3.0","environment":"development","requestTimestamp":"2026-05-13T21:43:31.611Z","responseTimestamp":"2026-05-13T21:43:33.072Z","datasourceDurationMillis":1460,"transactionId":"c1622227-4775-4282-9a65-07dd9fdd4205"},"rawData":{"data":{"permanent_and_total":{"service_connected_status":true,"pension_award_status":false},"total_disability":{"status":true,"effective_date":"1983-05-01"}}}}%    

…N based lookup, as well as disability determinations
@iannorriswork iannorriswork requested a review from a team May 13, 2026 21:45
@iannorriswork iannorriswork merged commit f67f3a1 into main May 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants