Skip to content

Conversation

@Illiwom
Copy link
Contributor

@Illiwom Illiwom commented Feb 29, 2024

  • Added functionality for hiding anonymous posts from user profiles
  • Added tests to check for minimum and maximum post lengths for students
  • Added tests to check for minimum and maximum post lengths for instructors
    • Added tests to check for minimum and maximum post title lengths for students
  • Added tests to check for minimum and maximum post title lengths for instructors
  • Added parameters for minimum and maximum post title length for instructors
  • Passes linter and testing suite

resolves #3

Screenshots:
aa1
aa2

…ded tests for minimum and maximum post lengths and titles for students and instructors.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8099599196

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 85.196%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/posts/create.js 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
src/notifications.js 1 82.91%
src/database/postgres/transaction.js 2 52.38%
Totals Coverage Status
Change from base Build 7964460060: -0.01%
Covered Lines: 22686
Relevant Lines: 25393

💛 - Coveralls

Copy link
Contributor

@TevinWang TevinWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Is it fine if you could add some before and after screenshots?

Copy link
Contributor

@nyzch nyzch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Illiwom
Copy link
Contributor Author

Illiwom commented Feb 29, 2024

LGTM! Is it fine if you could add some before and after screenshots?

Yes, Added!

@Illiwom Illiwom merged commit 01b7771 into main Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide posts in user section that are anonymous

5 participants