Conversation
kkosang
approved these changes
Apr 3, 2025
| - name: Analyze code | ||
| run: flutter analyze | ||
|
|
||
| - name: Check code formatting |
Collaborator
Author
There was a problem hiding this comment.
맞습니다 ci와 버전을 맞췄음에도 불구하고
로컬에서 dart format . 을 하면 바꿀 것이 없다고 뜨는데
ci 에선 한 개가 변화가 있다고 뜨네요
줄 바꿈에 문제가 있는 것이라고 추측이 되는데 이 부분 때문에 무엇을 추가한다기 보단 일단 뺐습니다.
Collaborator
There was a problem hiding this comment.
오홍 그렇군요 ! 필수적인 부분은 아니니까 빼고 작업하는 것도 좋은 거 같아요~
|
|
||
| class AppTypography { | ||
| static const header1 = | ||
| TextStyle(fontSize: 28, fontWeight: FontWeight.bold, height: 10 / 7); |
Collaborator
There was a problem hiding this comment.
height 프로퍼티는 무슨 기준인가요??
피그마에서는 40이라고 되어 있는데 !
Collaborator
Author
There was a problem hiding this comment.
폰트 * height가 = 피그마 에 나온 값이라고 생각하시면 됩니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
close #
📝작업 내용
스크린샷 or 작업영상
💬리뷰 요구사항