Add instrument bounds to L1 data plots #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
If the plot has no out-of-bounds data, it doesn't get any dashed lines: 
|
* Move site files into their own folder * Move README files into their own folder * Move file-info step into metadata helper file * Move and rename variables metadata * Move site-metadata insertion code to helper file * Move NA, tz, version insertion to helper file
Member
|
I had some thoughts on this PR but I'm out for an appointment until 12. Should I make a new issue? |
Member
Author
|
Crap, I'm sorry. Yes please, give feedback in an issue and I will address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds dashed lines showing the instrument bounds to plots with out-of-range data:
For comparison, the previous plots looked like this:
Note that the y axis also now has the variable name and units, something requested long ago by Xingyuan.
Closes #316