cli: Added short flags#100
Merged
VoyTechnology merged 1 commit intodevelopfrom Oct 22, 2017
Merged
Conversation
DarraghGriffin
approved these changes
Oct 20, 2017
ConorGriffin37
approved these changes
Oct 20, 2017
GoldenBadger
requested changes
Oct 21, 2017
| .arg( | ||
| Arg::with_name("input") | ||
| .long("input") | ||
| .short("in") |
Contributor
There was a problem hiding this comment.
Short should always be 1 character.
| .arg( | ||
| Arg::with_name("binary") | ||
| .long("binary") | ||
| .short("bin") |
| .arg( | ||
| Arg::with_name("output") | ||
| .long("output") | ||
| .short("out") |
VoyTechnology
force-pushed
the
feature/cli-short-commands
branch
2 times, most recently
from
8a11614 to
ef00623
Compare
| .short("o") | ||
| .help("Output Directory, optional") | ||
| .takes_value(true) | ||
| .default_value(""), |
Contributor
There was a problem hiding this comment.
On line 55 you explicitly mark it as not required, but not here. I like the explicitness.
GoldenBadger
approved these changes
Oct 22, 2017
VoyTechnology
force-pushed
the
feature/cli-short-commands
branch
from
7989049 to
67cbaee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@GoldenBadger While this is a convenience thing, I realize that having the short flags have multiple chars is not the best solution. As the Unix expert here, should I make them shorter to
-m-b,-i,-oand-t(in place of-idinstatus,-tas intask), or is this acceptable?