Initial commit of libcerberus.#26
Merged
GoldenBadger merged 1 commit intodevelopfrom Oct 4, 2017
Merged
Conversation
Includes error_chain setup code and a very basic test + function example.
DarraghGriffin
approved these changes
Oct 4, 2017
| "checksum libc 0.2.31 (registry+https://github.com/rust-lang/crates.io-index)" = "d1419b2939a0bc44b77feb34661583c7546b532b192feab36249ab584b86856c" | ||
| "checksum rustc-demangle 0.1.5 (registry+https://github.com/rust-lang/crates.io-index)" = "aee45432acc62f7b9a108cc054142dac51f979e69e71ddce7d6fc7adf29e817e" | ||
| "checksum winapi 0.2.8 (registry+https://github.com/rust-lang/crates.io-index)" = "167dc9d6949a9b857f3451275e911c3f44255842c1f7a76f33c55103a909087a" | ||
| "checksum winapi-build 0.1.1 (registry+https://github.com/rust-lang/crates.io-index)" = "2d315eee3b34aca4797b2da6b13ed88266e6d612562a0c46390af8299fc699bc" |
There was a problem hiding this comment.
Why did you do this rust, so ugly :(
Contributor
Author
There was a problem hiding this comment.
It's designed to be "user readable", apparently :P. Anyway it's just used to keep state between all of the crates in the workspace.
ConorGriffin37
requested changes
Oct 4, 2017
| @@ -0,0 +1,7 @@ | |||
| [package] | |||
| name = "cerberus" | |||
There was a problem hiding this comment.
Should this be libcerberus? Since it seems to be referred to that in the top level workspace members.
Contributor
Author
There was a problem hiding this comment.
This is the name the crate will have when (if) it is published. Other parts of the project that depend on this will use the name cerberus. The directory it lives in is libcerberus however. I gave it that name to make it obviously the directory containing the library.
ConorGriffin37
approved these changes
Oct 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes error_chain setup code and a very basic test + function example.