Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ A "SafeScale `Feature`" is a file in YAML format that describes the operations t
A `Feature` can describe operations using different methods:
- `package`: just define the package(s) concerned
- `bash`: uses bash snippets
- `helm` (coming soon): uses helm chart, the "package" engine for Kubernetes
- `ansible` (coming soon): defines playbook to run, SafeScale provising inventory
- `helm`: uses helm chart, the "package" engine for Kubernetes
- `ansible`: defines playbook to run, SafeScale provising inventory

Additionally, a `Feature` is able to apply:
- reverse proxy rules
Expand Down
10 changes: 9 additions & 1 deletion lib/backend/resources/operations/metadatacore.go
Original file line number Diff line number Diff line change
Expand Up @@ -311,10 +311,18 @@ func (myself *MetadataCore) Inspect(inctx context.Context, callback resources.Ca
}
}

func (myself *MetadataCore) Review(inctx context.Context, callback resources.Callback) (rerr fail.Error) {
if valid.IsNil(myself) {
return fail.InvalidInstanceError()
}

return myself.Inspect(inctx, callback)
}

// Review allows to access data contained in the instance, without reloading from the Object Storage; it's intended
// to speed up operations that accept data is not up-to-date (for example, SSH configuration to access host should not
// change through time).
func (myself *MetadataCore) Review(inctx context.Context, callback resources.Callback) (rerr fail.Error) {
func (myself *MetadataCore) OldReview(inctx context.Context, callback resources.Callback) (rerr fail.Error) {
if valid.IsNil(myself) {
return fail.InvalidInstanceError()
}
Expand Down
13 changes: 11 additions & 2 deletions lib/backend/resources/operations/metadatacore_debug.go
Original file line number Diff line number Diff line change
Expand Up @@ -319,10 +319,19 @@ func (myself *MetadataCore) Inspect(inctx context.Context, callback resources.Ca
}
}

// Review allows to access data contained in the instance, without reloading from the Object Storage; it's intended
// Review just calls Inspect
func (myself *MetadataCore) Review(inctx context.Context, callback resources.Callback) (rerr fail.Error) {
if valid.IsNil(myself) {
return fail.InvalidInstanceError()
}

return myself.Inspect(inctx, callback)
}

// OldReview allows to access data contained in the instance, without reloading from the Object Storage; it's intended
// to speed up operations that accept data is not up-to-date (for example, SSH configuration to access host should not
// change through time).
func (myself *MetadataCore) Review(inctx context.Context, callback resources.Callback) (rerr fail.Error) {
func (myself *MetadataCore) OldReview(inctx context.Context, callback resources.Callback) (rerr fail.Error) {
defer func() {
if rerr != nil {
if myself != nil {
Expand Down