Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enrollment flow polish + Jest service testing framework
♻️ Current situation & Problem
This PR improves overall stability and developer velocity by:
There are no linked issues or prior PRs associated with this change.
⚙️ Release Notes
CLAUDE.mdto reflect the current enrollment flow and testing approach.Notes / migration
npm testnpm run test:services📚 Documentation
CLAUDE.mdto align with the current enrollment flow and testing setup.✅ Testing
Framework: Jest
Actively tested (running now)
These tests run as part of
npm test/npm run test:services:Flagged / skipped (waiting for implementation)
These tests are present but intentionally skipped until feature flags are enabled:
getMeasurementsandgetLatestMeasurementreal API calls are skippedFEATURE_FLAGS.THRONE_API_IMPLEMENTED(currentlyfalse)FEATURE_FLAGS.FIREBASE_BACKEND_IMPLEMENTED(currentlyfalse)Why some elements are not fully testable yet