Dev fixes#28
Merged
Merged
Conversation
- Add get_vault_client() helper to refresh JWT tokens before Vault operations (JWT SVIDs expire after 1h, Vault tokens after 24h) - Change workload selector from docker:image_id: to unix:uid:0 (Docker attestor not working, all client containers run as root) - Add chmod 777 for SPIRE agent socket after creation (Fixes socket permission issues preventing SVID fetching) These changes fix the client registration failures and allow data/container/job preparation workflows to complete successfully.
Container building can somewhat confusingly fail when the sif image already exists, or when the host /tmp ends up getting mounted to the build container's /output. These are intended to defaultly avoid those problems, and provide some configurability.
Previously, "follow" meant to stream job log output, and otherwise we persisted with the job, printing changes in its status. Now, "follow" means the old default state, --verbose means to stream the job log, and the default is to exit after the job has been submitted.
First wait, then check if process died, then print that we're waiting some more. This way there's usually no concerning needless printing.
(Because of the need to use our own binary which may not be able to access system's LDAP, this is why we also need to use UID attestation instead of username)
mmatthiesencsc
approved these changes
Apr 1, 2026
Collaborator
mmatthiesencsc
left a comment
mmatthiesencsc
left a comment
There was a problem hiding this comment.
Looks good, great steps ahead. I created #29 but that is for later to decide.
Collaborator
|
The checks fail in part because of missing LFS budget. Ignoring for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various issues prevented the client commands from completing successfully. This branch at least makes things complete, though some things should still be fixed more correctly.
Many changes have stupidly been piled on this same PR, we'll review with some team and see if this is mergeable.