CSCEXAM-984 Add new view to admin view rooms list #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
WIP |
lupari
reviewed
Sep 21, 2022
| interface RoomWithAddressVisibility extends ExamRoom { | ||
| addressVisible: boolean; | ||
| availabilityVisible: boolean; | ||
| extendedDWH: DefaultWorkingHoursWithEditing[]; |
Collaborator
There was a problem hiding this comment.
Näissä ois hyvä käyttää camel-casea eli extendedDwh
lupari
reviewed
Sep 21, 2022
| this.room.updateWorkingHours$(this.room.getWeek(), [examRoom.id]); | ||
| wh.editing = false; | ||
| } | ||
| deleteDWH(wh: DefaultWorkingHoursWithEditing) { |
Collaborator
Author
There was a problem hiding this comment.
Tää oli just se mikä oli tän tiketin kohdalla jäänyt kesken. En osannut vääntää DefaultWorkingHours objektista semmosta että sen olisi voinut näyttää uudessa näkymässä ja takaisin. Tällä funktiolla oli tarkoitus poistaa DefaultWorkingHours jos sinne asti olisin päässyt.
lupari
approved these changes
Sep 21, 2022
| isArchived = (machine: ExamMachine) => { | ||
| return machine.archived === false; | ||
| }; | ||
| startEditing(wh: DefaultWorkingHoursWithEditing) { |
Collaborator
There was a problem hiding this comment.
Voisi käyttää arrow-funktiota näissä yksirivisissä
lupari
approved these changes
Oct 4, 2022
VirmasaloA
force-pushed
the
CSCEXAM-984-985
branch
from
d622b82 to
829ddda
Compare
VirmasaloA
force-pushed
the
CSCEXAM-984-985
branch
from
829ddda to
074822e
Compare
lupari
force-pushed
the
CSCEXAM-984-985
branch
6 times, most recently
from
56877cb to
da7df9b
Compare
lupari
force-pushed
the
CSCEXAM-984-985
branch
from
da7df9b to
015c985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.