Skip to content

make dockerfiles build pyproject.toml #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2023
Merged

make dockerfiles build pyproject.toml #1031

merged 2 commits into from
Mar 14, 2023

Conversation

@blankdots
Copy link
Contributor

@blankdots blankdots commented Mar 13, 2023 •
edited
Loading

Description

Using hatch as a build tool seems to have issues with finding the symbolic link of the static folder (and seems poetry has similar issues). Switching to setuptools seems to create more issues, so trying the next best thing which is remove the symbolic link from dockerfiles.

This was introduced in: #984

Related issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • small additions in pyproject.toml
  • remove static folder from dockefiles so that build can happen normally

Testing

  • Tests do not apply

Mentions

@blankdots blankdots self-assigned this Mar 13, 2023
@blankdots blankdots changed the title try to use setuptools build system use setuptools build system Mar 13, 2023
@blankdots blankdots force-pushed the bugfix/build-system-docker branch from 10c282a to 2683477 Compare March 13, 2023 14:56
@blankdots blankdots force-pushed the bugfix/build-system-docker branch from 2683477 to d0ef5f6 Compare March 13, 2023 15:19
@blankdots blankdots changed the title use setuptools build system make dockerfiles build pyproject.toml Mar 13, 2023
@blankdots blankdots marked this pull request as ready for review March 13, 2023 15:21
csc-felipe
csc-felipe reviewed Mar 14, 2023
View reviewed changes
csc-felipe
csc-felipe reviewed Mar 14, 2023
View reviewed changes
csc-felipe
csc-felipe reviewed Mar 14, 2023
View reviewed changes
@blankdots blankdots force-pushed the bugfix/build-system-docker branch from d0ef5f6 to eda7069 Compare March 14, 2023 06:06
@blankdots blankdots force-pushed the bugfix/build-system-docker branch from eda7069 to 0a5f7a9 Compare March 14, 2023 06:08
@blankdots blankdots requested a review from csc-felipe March 14, 2023 07:43
@csc-felipe csc-felipe merged commit 22c1112 into devel Mar 14, 2023
@csc-felipe csc-felipe deleted the bugfix/build-system-docker branch March 14, 2023 07:46
blankdots pushed a commit that referenced this pull request Jun 13, 2023
Merge branch 'bugfix/large-upload' into 'devel'
2129f50 
Bugfix/large upload issues

Closes #1018, #1015, #1031, and #1037

See merge request sds-dev/sd-connect/swift-browser-ui!49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampsapenna sampsapenna Awaiting requested review from sampsapenna

1 more reviewer

@csc-felipe csc-felipe csc-felipe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@blankdots blankdots

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blankdots @csc-felipe