Migrate to using pyproject.toml with hatch as build tool #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csc-felipe
force-pushed
the
feature/pyproject
branch
from
52f6d67 to
336d28f
Compare
csc-felipe
force-pushed
the
feature/pyproject
branch
from
730ab21 to
7f62900
Compare
csc-felipe
force-pushed
the
feature/pyproject
branch
from
7f62900 to
801240f
Compare
blankdots
approved these changes
Feb 27, 2023
Contributor
blankdots
left a comment
blankdots
left a comment
There was a problem hiding this comment.
i think this could can be merged, as it does not affect that much the current development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
pyproject.tomlseems to be the recommended way for building and installing python projects.Nothing else needs to change, the project still installs as usual with
pip.The build system is now hatch, as it was one of the recommended tools, and is an official project. It has quite many features, but we don't even need to install it.
Related issues
Type of change
Changes Made
setup.pytopyproject.tomldistfolder, otherwise the build tries to resolve it as a local directory, and fails to install when it doesn't existcryptography, as dependency review flagged the current version as vulnerableTesting
Mentions
I was wondering if we should remove the requirements file, as it is not necessarily needed. Any opinions?