Devel #18
Merged
Devel #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return value check is not necessary, since all the failure conditions present in check_csrf lead to an exception, there is no viable execution path which could lead to the check being not True while having the check_csrf function not throw.
Api session validity check function unit tests were not properly formed, leading to lower than expected testing coverage. The edge cases of the session validity checks are now tested for.
Added tests for testing openstack active project api call, unicode null filtering and swift error handling in container listing.
Add locust file for rudimentary API performance testing.
HTTPS was previously disabled in standalone mode (not running with a TLS termination proxy) due to difficulties in getting it properly running. Now the problems are fixed and running with HTTPS has been enabled again. Also added CLI options for specifying the SSL certificates for HTTPS.
Feature/middleware tests
Feature/enable standalone ssl support
blankdots
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase test coverage over the backend, as well as add the possibility for API performance testing. Add HTTPS back as an option when running the server.
Type of change
Changes Made
run_server_securefunction to enable running with HTTPS enabled.Testing