Skip to content

Conversation

@blankdots
Copy link
Contributor

Description

dependabot creates a lot of dependency updates, auto-merge them if they have specific labels and all the tests pass

Related issues

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

Added 2 new workflows:

  • dependency review which checks dependencies for know vulnerabilities moderate or higher
  • dependency auto merge, which has 2 steps first one waits for other actions to finish for 30 minutes, and the other merges the PR if all actions are successful. this is done only for PRs with labels pip dependencies, npm dependencies and github actions, the docker dependencies is not added as that sometimes update python or npm versions and that creates issues

Testing

  • Tests do not apply

Mentions

From the tests this works about 95% of the time, sometimes it does not recognize the label and a @dependabot recreate is required

- add actions for dependency review security issues
- add action to auto merge dependencies
@blankdots blankdots force-pushed the feature/dependanbot-auto-merge branch from 6d2a25b to 5cbd54d Compare November 11, 2022 08:07
@blankdots
Copy link
Contributor Author

not sure this should be merged if we removed the e2e tests ... as if we have no tests, breaking dependency changes might be merged so we might need #824

@csc-felipe
Copy link
Contributor

Perhaps remove auto approving npm packages, but leave others.

@blankdots
Copy link
Contributor Author

Perhaps remove auto approving npm packages, but leave others.

done

@sampsapenna
Copy link
Member

not sure this should be merged if we removed the e2e tests ... as if we have no tests, breaking dependency changes might be merged so we might need #824

e2e tests would also greatly benefit from some changes to the testing workflow, i.e. building an initial state once and performing all the tests without starting from scratch with a new browser session every time. Having to rebuild the IDB for every test is causing a large part of the flakiness, and the rest is from poor API optimization.

We need to fix them before upgrading to Vue 3 though, and I want to write a few new tests for the frontend as well. The eventual upgrade will be a lot simpler if most of the things are part of e2e.

Copy link
Member

@sampsapenna sampsapenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 This seems like a very nice addition

@blankdots blankdots merged commit b5c5a88 into devel Nov 15, 2022
@blankdots blankdots deleted the feature/dependanbot-auto-merge branch November 15, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants