Bugfix/small window modal behaviour #986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Again forgot to change master->devel, so there are dependency problems that do not go away. |
Contributor
|
Funny that it has some formatting complaints |
blankdots
previously approved these changes
Feb 27, 2023
Contributor
|
i think this branch might need an update to |
blankdots
dismissed
their stale review
might need to rebase to make style checks pass
Contributor
|
Besides the style check error, the fix looks good to me :) |
Contributor
|
The modal definitely looks better when resized now! |
blankdots
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create folder modal does not shrink needlessly for smaller windows.
Related issues
Fixes Gitlab issue #929
Type of change
Testing