Skip to content

Gulp config and github actions#49

Merged
urchykli merged 4 commits intodevelopmentfrom
bug/gulp-config
May 14, 2021
Merged

Gulp config and github actions#49
urchykli merged 4 commits intodevelopmentfrom
bug/gulp-config

Conversation

@urchykli
Copy link
Copy Markdown
Member

In this PR I updated the gulpfile.js to look at gulp.config.js for the theme_dir and sass configurations rather than config.json. This allowed use of Local by flywheel.

Additionally, I set up github actions and added the .github directory to the repo.

@urchykli urchykli requested a review from jnschrag May 13, 2021 18:00
@urchykli urchykli changed the base branch from main to development May 13, 2021 19:14
Copy link
Copy Markdown
Contributor

@jnschrag jnschrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, @urchykli. I had one comment about including the git-include/exclude files in the deploy.yml file, but I think this is good to go if you want to merge it in.

Comment thread .github/workflows/wpengine-deploy.yml Outdated
WPE_SSH_KEY_PUBLIC: ${{ secrets.WPE_SSH_KEY_PUBLIC }}
# WPE_ENVIRONMENT: "production"
# WPE_LOCAL_BRANCH: "main"
# WPE_GIT_INCLUDE: ".github/wpe-git-include.txt"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to leave the Git include/exclude lines in there. You can remove the other two (environment & local branch).

@urchykli urchykli merged commit 3f1b162 into development May 14, 2021
@urchykli urchykli deleted the bug/gulp-config branch May 14, 2021 16:02
urchykli added a commit that referenced this pull request May 14, 2021
* Delete MAMP PRO logo

* Gulp config and github actions (#49)

* Update gulpfile to use gulp config instead of config.json to make site work with Local by flywheel

* Add github files for github actions deployment

* Update github workflow to deploy to multiple environments

* Git include and exclude files included in git deploy workflow

* Define local branch names in github deploy script

* Fix run syntax in GH deploy script

* Change GH WPE deployment script to single site

* Update secret key name and local branch in deployment script

* Update wpengine-deploy.yml

* Remove working directory in WPE deploy script

* Revert to reconcile merge conflicts

* Remove working directory in WPE deploy script

* Gulp config points to correct sass src directory

* Bug/aside images (#50)

* Removed $.trim from tinymce.js on insert function.

* Updatepackage lock

* Remove node sass

* Reinstall node sass

* Remove cache npm from travis file as it's causing the build to error

* Install node-gyp

* Remove node-sass

* In travis file change npm ci to npm install

* Update package.json and run npm install

Co-authored-by: MrBachChoi <55605733+MrBachChoi@users.noreply.github.com>

* Update readme with correct gulp config file

Co-authored-by: Jacque Schrag <jnschrag@users.noreply.github.com>
Co-authored-by: MrBachChoi <55605733+MrBachChoi@users.noreply.github.com>
jdromero88 pushed a commit that referenced this pull request Jan 8, 2025
* Update gulpfile to use gulp config instead of config.json to make site work with Local by flywheel

* Add github files for github actions deployment

* Update github workflow to deploy to multiple environments

* Git include and exclude files included in git deploy workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants