Skip to content

Add support for animation-fill-mode#102

Merged
nzakas merged 1 commit intoCSSLint:masterfrom
stmichael:101_animation_fill_mode
Feb 1, 2014
Merged

Add support for animation-fill-mode#102
nzakas merged 1 commit intoCSSLint:masterfrom
stmichael:101_animation_fill_mode

Conversation

@stmichael
Copy link
Copy Markdown
Contributor

As far as I can tell not all properties are covered in the tests. I personally find it useful to have a regression test for such a case. So I added one although I'm not sure if I placed it in the right file.

According to http://www.w3schools.com/cssref/css3_pr_animation-fill-mode.asp only webkit needs a prefixed version of animation-fill-mode.

Could you please review the code. Thanks. 😃

@stmichael
Copy link
Copy Markdown
Contributor Author

Sorry for the mixup. This pull request was actually meant to be in #101.

nzakas added a commit that referenced this pull request Feb 1, 2014
@nzakas nzakas merged commit 283c0f1 into CSSLint:master Feb 1, 2014
@stmichael stmichael deleted the 101_animation_fill_mode branch February 1, 2014 19:23
@stmichael
Copy link
Copy Markdown
Contributor Author

Do you plan on releasing this patch soon for npm?

@nzakas
Copy link
Copy Markdown
Contributor

nzakas commented Feb 1, 2014

I usually wait until there are a few fixes to bundle together before doing
a new release, unless there's an urgent issue someone has.

@alexilyaev
Copy link
Copy Markdown

@nzakas Hi, I was wondering when can we expect it to be on npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants