MediaQuery.text minor bug

[mirceapiturca]

MediaQuery mediaType and features needs to be joined trough "and".

For example parsing "only screen and (min-width:450px) and (max-width:1950px)", the text output will be
"only screen (min-width:450px) and (max-width:1950px)".
It is parsed right but the new text string will be invalid if matched with window.matchMedia

Thank you.

[travisbot]

This pull request passes (merged 74592d6 into 63fd3bf).

[nzakas]

Thanks for the pull request, but this isn't the right location for such a fix. You actually need to make a change in the source file not in the completely built file.

[mirceapiturca]

Sorry about this. Indeed I see that the right file is parser-lib /src /css/MediaQuery.js. Should I do another pull request with the right file?

Thank for this wonderful piece of work!

[nzakas]

Yep, that's the right place to do it. If you could also add in some unit tests that verify this new functionality, I would be very appreciative.

[travisbot]

This pull request passes (merged 081dddb into 63fd3bf).

[mirceapiturca]

Added the change at the right file src/css/MediaQuery.js and set up a small test using the modified parser functionality at: http://typefolly.com/nzakas-parser-lib-63fd3bf/tests/css/CSSMediaQueryTests.html.
Not sure if this is the right way to do it.
Thank you.

[nzakas]

Sorry for the delay, I was traveling. The test should be done as a standalone JavaScript file kind of like this: https://github.com/nzakas/parser-lib/blob/master/tests/css/Parser.js

That way, it automatically gets picked up by the build and run.

[mirceapiturca]

Sorry, I have not done unit testing. So basically all I have to do is to add my tests to the Parser.js file from my forked version? Thanks.

[nzakas]

Yup

[mirceapiturca]

I've appended a MediaQuery.text test onto the existing tests. Hope it will work.

[nzakas]

It looks like the tests are failing (according to the Travis build - sorry about it not turning red, I need to fix that).