Skip to content

Conversation

@SLaks
Copy link

@SLaks SLaks commented Nov 21, 2012

The MediaQuery.text property leaves out an and token between the media type and the features.
It also adds an extra trailing space.

I fixed it, and modified the test cases to report the error.

@SLaks
Copy link
Author

SLaks commented Nov 21, 2012

I just noticed that this is a duplicate of #30; sorry.

The tests there were failing because the parser strips spaces before values.

@SLaks
Copy link
Author

SLaks commented Nov 26, 2012

Can you release the latest (including #30) version to NPM?
I need this fix, and there is no convenient way for me to reference this from GitHub. (since there is no package.json in the repository root)

@SLaks SLaks closed this Nov 26, 2012
@nzakas
Copy link
Contributor

nzakas commented Dec 4, 2012

Just pushed to npm.

On Mon, Nov 26, 2012 at 11:23 AM, SLaks notifications@github.com wrote:

Can you release the latest (including #30#30)
version to NPM?

I need this fix, and there is no convenient way for me to reference this
from GitHub. (since there is no package.json in the repository root)


Reply to this email directly or view it on GitHubhttps://github.com//pull/47#issuecomment-10729653.


Nicholas C. Zakas
@SlickNet

Author, Professional JavaScript for Web Developers
Buy it at Amazon.com:
http://www.amazon.com/Professional-JavaScript-Developers-Nicholas-Zakas/dp/1118026691/ref=sr_1_3

@nschonni
Copy link
Member

nschonni commented Dec 4, 2012

What's the process of getting these changes over to CSSLint?

@nzakas
Copy link
Contributor

nzakas commented Dec 4, 2012

They just have to be merged in. If you want to try it yourself, checkout
the CSS Lint repo and run ant parser.update, then ant test to verify
nothing broke. If that works, then it's safe to commit.

On Tue, Dec 4, 2012 at 12:39 PM, Nick Schonning notifications@github.comwrote:

What's the process of getting these changes over to CSSLint?


Reply to this email directly or view it on GitHubhttps://github.com//pull/47#issuecomment-11014710.


Nicholas C. Zakas
@SlickNet

Author, Professional JavaScript for Web Developers
Buy it at Amazon.com:
http://www.amazon.com/Professional-JavaScript-Developers-Nicholas-Zakas/dp/1118026691/ref=sr_1_3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants