Skip to content

Various fixes on Elections API #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 26, 2025
Merged

Various fixes on Elections API #112

merged 6 commits into from
Aug 26, 2025

Conversation

@jbriones1
Copy link
Contributor

@jbriones1 jbriones1 commented Aug 26, 2025 •
edited
Loading

  • Added a response model for the elections and nominee endpoints
  • Fixed some invalid HTTP 404 status code returns
  • Fixed some return type issues on user validations functions

@jbriones1 jbriones1 requested a review from p-north August 26, 2025 04:26
p-north
p-north reviewed Aug 26, 2025
View reviewed changes
p-north
p-north approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@p-north p-north left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Looks good overall

@jbriones1 jbriones1 merged commit fd23837 into main Aug 26, 2025
3 checks passed
@jbriones1 jbriones1 deleted the fix_batch-1 branch August 26, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p-north p-north p-north approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbriones1 @p-north